Skip to content

Updating mapping to double for long #326

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 10 commits into from
Apr 25, 2025

Conversation

johnmichaelmurner
Copy link
Contributor

@johnmichaelmurner johnmichaelmurner commented Jan 16, 2025

Related Issue(s):

#320

Description:

Convert dynamic mapping from

{"numerics": {"match_mapping_type": "long", "mapping": {"type": "float"}}},
{"numerics": {"match_mapping_type": "long", "mapping": {"type": "double"}}},

PR Checklist:

  • Code is formatted and linted (run pre-commit run --all-files)
  • Tests pass (run make test)
  • Documentation has been updated to reflect changes, if applicable
  • Changes are added to the changelog

@StijnCaerts
Copy link
Collaborator

Best to keep the mapping for Opensearch in sync with Elasticsearch:

{"numerics": {"match_mapping_type": "long", "mapping": {"type": "float"}}},

https://opensearch.org/docs/latest/field-types/supported-field-types/numeric/

@jonhealy1
Copy link
Collaborator

@johnmichaelmurner Hi. Are you able to add your changes to the main database_logic.py file in the core folder? https://github.com/stac-utils/stac-fastapi-elasticsearch-opensearch/blob/main/stac_fastapi/core/stac_fastapi/core/database_logic.py Things have moved around and it would be nice to merge this pr. Thank you

@jonhealy1 jonhealy1 self-requested a review April 24, 2025 15:05
jonhealy1
jonhealy1 previously approved these changes Apr 24, 2025
Copy link
Collaborator

@jonhealy1 jonhealy1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice work here @johnmichaelmurner. I made a couple edits because the codebase has changed lately. Thank you.

@jonhealy1 jonhealy1 self-requested a review April 25, 2025 08:32
@jonhealy1 jonhealy1 merged commit 64d646f into stac-utils:main Apr 25, 2025
65 of 75 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants