Skip to content

Conversation

@rhysrevans3
Copy link
Collaborator

@rhysrevans3 rhysrevans3 commented Apr 12, 2024

Description:

Adding the free-text search extension. Related to stac-utils/stac-fastapi#655

PR Checklist:

  • Code is formatted and linted (run pre-commit run --all-files)
  • Tests pass (run make test)
  • Documentation has been updated to reflect changes, if applicable
  • Changes are added to the changelog

@rhysrevans3
Copy link
Collaborator Author

I've not included FreeTextAdvancedExtension as I don't think it works in it's current form and expect it will be removed in the future.

@rhysrevans3 rhysrevans3 marked this pull request as ready for review August 30, 2024 09:42
@jonhealy1 jonhealy1 self-requested a review August 30, 2024 13:29
Copy link
Collaborator

@jonhealy1 jonhealy1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Super

Copy link
Collaborator

@jamesfisher-geo jamesfisher-geo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Look great!

How do you feel about adding other fields like Collection and Item titles to the free-text search in the future?

@jonhealy1 jonhealy1 merged commit ae5588e into stac-utils:main Aug 31, 2024
@rhysrevans3 rhysrevans3 deleted the free-text-search branch September 2, 2024 07:50
@rhysrevans3
Copy link
Collaborator Author

@jamesfisher-geo yes I'll make a new pull request to add those fields. Alternately it could just search all fields instead?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants