Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Allow for generic auth headers with pystac + validators #392

Merged
merged 8 commits into from
Oct 7, 2024
Merged

Allow for generic auth headers with pystac + validators #392

merged 8 commits into from
Oct 7, 2024

Conversation

gadomski
Copy link
Member

This is a re-try of #316, which failed CI on main because it was merged with pretty stale CI checks by me (@gadomski).

@gadomski gadomski mentioned this pull request Feb 14, 2024
Merged
2 tasks
@vprivat-ads
Copy link
Contributor

we would need this change for our project, to be able to pass a custom api key header, is there something I can do to help?

@gadomski gadomski enabled auto-merge (squash) October 4, 2024 20:49
@gadomski gadomski requested review from hrodmn and removed request for philvarner October 4, 2024 20:50
@gadomski gadomski self-assigned this Oct 4, 2024
@gadomski
Copy link
Member Author

gadomski commented Oct 4, 2024

Thanks for the ping @vprivat-ads ... I've brought the PR up-to-date and fixed some tests, so we should be able to merge+release before too long.

@vprivat-ads
Copy link
Contributor

Thank you!

@vprivat-ads vprivat-ads mentioned this pull request Oct 7, 2024
Merged
hrodmn
hrodmn previously approved these changes Oct 7, 2024
View reviewed changes
Copy link
Collaborator

@hrodmn hrodmn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This all looks good to me, though the tests are not going to be resilient to changes in the requests version. I suggested a small change to avoid having to update that test if/when we upgrade to a new version of requests.

tests/test_main.py Outdated Show resolved Hide resolved
tests/test_validations.py Outdated Show resolved Hide resolved
@gadomski gadomski requested a review from hrodmn October 7, 2024 12:05
@gadomski gadomski merged commit 87c4a2a into main Oct 7, 2024
8 checks passed
@gadomski gadomski deleted the retry-316 branch October 7, 2024 12:06
@vprivat-ads vprivat-ads mentioned this pull request Oct 8, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hrodmn hrodmn hrodmn approved these changes

Assignees

@gadomski gadomski

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@gadomski @vprivat-ads @hrodmn @john-dupuy