-
Notifications
You must be signed in to change notification settings - Fork 19
feat: specify max_row_group_size in geoparquet WriterBuilder #846
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
1b78bd8 to
31fe450
Compare
gadomski
requested changes
Nov 17, 2025
gadomski
requested changes
Nov 18, 2025
Member
gadomski
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the options fix, this feels nice. Just one tweak that might let us do fewer changes.
gadomski
requested changes
Nov 18, 2025
gadomski
approved these changes
Nov 18, 2025
Member
gadomski
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
![]()
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related to
this does not expose the max_row_group_size parameter through all of the CLI and format-based functions, but does make it configurable for any application that uses WriterBuilder directly (e.g. rustac-py's.GeoparquetWriter)Description
This adds the
max_row_group_sizeparameter togeoparquet::WriterBuilderand sets the default value to150_000(per recommendations in cholmes' guide.The rustac cli has a new option
--parquet-max-row-group-sizethat can be used to set the max_row_group_size on output geoparquet files.Checklist
Delete any checklist items that do not apply (e.g. if your change is minor, it may not require documentation updates).
cargo fmt)cargo test