Generalize return types from classmethods #983
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related Issue(s):
clone
shouldn't hard-code return type #863Description:
Use
TypeVar
for alternate constructors, e.g.from_dict
andfrom_file
. The keycast
that enables the whole inheritance tree to work is https://github.com/stac-utils/pystac/compare/issues/862-return-types?expand=1#diff-3f0f0b208e42045d63bb010a3b963e4178a8cf882f75f73d8392828b2190eafcR525.Includes some sidecar fixes:
clone
in a couple of places where it was missing, closingclone
shouldn't hard-code return type #863from __future__ import annotations
opportunities that were missed in Usefrom __future__ import annotations
#962PR Checklist:
pre-commit run --all-files
)scripts/test
)