Skip to content

Fix twice consumed iterators #912

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Jan 25, 2023
Merged

Conversation

gadomski
Copy link
Member

@gadomski gadomski commented Nov 8, 2022

Related Issue(s):

Description:

Fixes two tests that looped through iterators twice.

PR Checklist:

  • Code is formatted (run pre-commit run --all-files)
  • Tests pass (run scripts/test)
  • Documentation has been updated to reflect changes, if applicable
  • This PR maintains or improves overall codebase code coverage.
  • Changes are added to the CHANGELOG. See the docs for information about adding to the changelog.

@gadomski gadomski changed the title Issues/502 twice consumed iterators Fix twice consumed iterators Nov 8, 2022
@gadomski gadomski marked this pull request as draft November 8, 2022 23:30
@gadomski gadomski added the tests Issues or pull requests that relate to the test suite label Nov 9, 2022
@gadomski gadomski self-assigned this Jan 23, 2023
@gadomski gadomski force-pushed the issues/502-twice-consumed-iterators branch from 1a1a07e to 6475c45 Compare January 23, 2023 16:29
@gadomski gadomski marked this pull request as ready for review January 23, 2023 16:29
@gadomski gadomski requested a review from pjhartzell January 23, 2023 16:29
@gadomski gadomski added this to the 1.7 milestone Jan 23, 2023
@codecov-commenter
Copy link

Codecov Report

Base: 90.12% // Head: 90.12% // No change to project coverage 👍

Coverage data is based on head (db17944) compared to base (f44de3c).
Patch has no changes to coverable lines.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #912   +/-   ##
=======================================
  Coverage   90.12%   90.12%           
=======================================
  Files          47       47           
  Lines        6063     6063           
  Branches      909      909           
=======================================
  Hits         5464     5464           
  Misses        420      420           
  Partials      179      179           

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@gadomski gadomski force-pushed the issues/502-twice-consumed-iterators branch from e1bcf7b to 2e78539 Compare January 25, 2023 14:59
@gadomski gadomski force-pushed the issues/502-twice-consumed-iterators branch from 2e78539 to 7db533e Compare January 25, 2023 15:01
@gadomski gadomski requested a review from pjhartzell January 25, 2023 15:01
@gadomski gadomski merged commit 2a2366a into main Jan 25, 2023
@gadomski gadomski deleted the issues/502-twice-consumed-iterators branch January 25, 2023 15:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
tests Issues or pull requests that relate to the test suite
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Tests trying to loop more than once through iterators
3 participants