Skip to content

Bump jsonschema minimum version to avoid RefResolutionError #857

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Conversation

duckontheweb
Copy link
Contributor

@duckontheweb duckontheweb commented Jul 26, 2022

Related Issue(s):

Description:

Validating Collections with the Processing Extension led to a RefResolutionError when using jsonschema < 4.0. Since 4.0.1 was yanked from PyPi, we now pin to jsonschema>=4.0.1.

PR Checklist:

  • Code is formatted (run pre-commit run --all-files)
  • Tests pass (run scripts/test)
  • Documentation has been updated to reflect changes, if applicable
  • This PR maintains or improves overall codebase code coverage.
  • Changes are added to the CHANGELOG. See the docs for information about adding to the changelog.

@duckontheweb duckontheweb added this to the 1.7 milestone Jul 26, 2022
@duckontheweb duckontheweb requested review from gadomski and m-mohr July 26, 2022 13:16
@duckontheweb duckontheweb removed this from the 1.7 milestone Jul 26, 2022
@codecov-commenter
Copy link

codecov-commenter commented Jul 26, 2022

Codecov Report

Merging #857 (99c6eae) into main (106dfd4) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##             main     #857   +/-   ##
=======================================
  Coverage   94.32%   94.32%           
=======================================
  Files          83       83           
  Lines       11963    11963           
  Branches     1403     1403           
=======================================
  Hits        11284    11284           
  Misses        496      496           
  Partials      183      183           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 106dfd4...99c6eae. Read the comment docs.

Copy link
Contributor

@m-mohr m-mohr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested with 4.0.1 and the reported error doesn't occur anymore.

Copy link
Member

@gadomski gadomski left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There's a test-validation-error.json file at the top level of the repository -- is that intentional? IMO that file should be in tests/data-files and should be checked w/ a regression test.

@duckontheweb
Copy link
Contributor Author

There's a test-validation-error.json file at the top level of the repository -- is that intentional? IMO that file should be in tests/data-files and should be checked w/ a regression test.

Oops, sorry. I was using that to reproduce the original error. I reverted the commit that added this.

@duckontheweb duckontheweb requested a review from gadomski July 27, 2022 14:24
@duckontheweb duckontheweb merged commit a11e80f into stac-utils:main Jul 27, 2022
@duckontheweb duckontheweb deleted the fix/845-jsonschema-ref-resolver-error branch July 27, 2022 14:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Processing extension can't be used for validation?
4 participants