-
Notifications
You must be signed in to change notification settings - Fork 122
Bump jsonschema minimum version to avoid RefResolutionError #857
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Bump jsonschema minimum version to avoid RefResolutionError #857
Conversation
Codecov Report
@@ Coverage Diff @@
## main #857 +/- ##
=======================================
Coverage 94.32% 94.32%
=======================================
Files 83 83
Lines 11963 11963
Branches 1403 1403
=======================================
Hits 11284 11284
Misses 496 496
Partials 183 183 Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Tested with 4.0.1 and the reported error doesn't occur anymore.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There's a test-validation-error.json
file at the top level of the repository -- is that intentional? IMO that file should be in tests/data-files
and should be checked w/ a regression test.
This reverts commit aa39edf.
Oops, sorry. I was using that to reproduce the original error. I reverted the commit that added this. |
Related Issue(s):
Description:
Validating Collections with the Processing Extension led to a RefResolutionError when using
jsonschema
< 4.0. Since 4.0.1 was yanked from PyPi, we now pin tojsonschema>=4.0.1
.PR Checklist:
pre-commit run --all-files
)scripts/test
)