Use PropertiesExtension._get_property in table extension #712
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related Issue(s):
Description:
Uses
PropertiesExtension._get_property
inTableExtension
to properly set return type.There are no other extensions classes inheriting from
PropertiesExtension
that have a similar issue, but there are a number of similarbad-return-type
errors frompytype
resulting from vague typing in thesummaries
module and in some of the other dict-like classes in the extension modules. I will open a separate PR to address the typing issues in thesummaries
module, and I think the typing issues with the other dict-like classes would be best addressed in a PR that implements some of the JSON serde logic suggested in #700 (comment) and begun in #617.PR Checklist:
pre-commit run --all-files
)scripts/test
)