Skip to content

Use PropertiesExtension._get_property in table extension #712

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged

Conversation

duckontheweb
Copy link
Contributor

@duckontheweb duckontheweb commented Jan 14, 2022

Related Issue(s):

Description:

Uses PropertiesExtension._get_property in TableExtension to properly set return type.

There are no other extensions classes inheriting from PropertiesExtension that have a similar issue, but there are a number of similar bad-return-type errors from pytype resulting from vague typing in the summaries module and in some of the other dict-like classes in the extension modules. I will open a separate PR to address the typing issues in the summaries module, and I think the typing issues with the other dict-like classes would be best addressed in a PR that implements some of the JSON serde logic suggested in #700 (comment) and begun in #617.

PR Checklist:

  • Code is formatted (run pre-commit run --all-files)
  • Tests pass (run scripts/test)
  • Documentation has been updated to reflect changes, if applicable
  • This PR maintains or improves overall codebase code coverage.
  • Changes are added to the CHANGELOG. See the docs for information about adding to the changelog.

@duckontheweb duckontheweb requested a review from schwehr January 14, 2022 15:50
@codecov-commenter
Copy link

Codecov Report

Merging #712 (75f78c0) into main (5cff27d) will not change coverage.
The diff coverage is 0.00%.

❗ Current head 75f78c0 differs from pull request most recent head 98e60e2. Consider uploading reports for the commit 98e60e2 to get more accurate results
Impacted file tree graph

@@           Coverage Diff           @@
##             main     #712   +/-   ##
=======================================
  Coverage   94.20%   94.20%           
=======================================
  Files          77       77           
  Lines       11130    11130           
  Branches     1340     1340           
=======================================
  Hits        10485    10485           
  Misses        466      466           
  Partials      179      179           
Impacted Files Coverage Δ
pystac/extensions/table.py 69.93% <0.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 5cff27d...98e60e2. Read the comment docs.

@schwehr schwehr merged commit 55fe7ab into stac-utils:main Jan 14, 2022
@duckontheweb duckontheweb deleted the fix/677-extension-prop-return-type branch January 14, 2022 16:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

extensions/table.py: Not compatible with pytype
3 participants