Include typing information during packaging #579
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
4 tasks
cuttlefish
added a commit
to stac-utils/stactools
that referenced
this pull request
Jul 27, 2021
|
@duckontheweb Python packaging is not my forte, but this seems to work based on my testing. |
gadomski
pushed a commit
to stac-utils/stactools
that referenced
this pull request
Jul 27, 2021
There was a problem hiding this comment.
Thanks for this @cuttlefish!
Based on past experience and brushing up on the Data Files Support docs I think it might be best to just use package_data and not include_package_data (see specific comments below). Let me know what you think.
|
Thanks so much @duckontheweb! You're right about |
cuttlefish
added a commit
to stac-utils/stactools
that referenced
this pull request
Jul 28, 2021
5 tasks
cuttlefish
added a commit
to stac-utils/stactools
that referenced
this pull request
Jul 28, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related Issue(s):
stac-utils/stactools#155
Description:
This includes type information in the packages so that users of
pystaccan utilize it. This is particularly useful if the downstream project usesmypyor any of its competitors.PR Checklist:
pre-commit run --all-files)scripts/test)[ ] Documentation has been updated to reflect changes, if applicable