Skip to content

Update Item Assets Extension #564

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged

Conversation

duckontheweb
Copy link
Contributor

@duckontheweb duckontheweb commented Jul 17, 2021

Related Issue(s):

Description:

Updates docstrings and adds tests for the Item Assets Extension.

PR Checklist:

  • Code is formatted (run pre-commit run --all-files)
  • Tests pass (run scripts/test)
  • Documentation has been updated to reflect changes, if applicable
  • This PR maintains or improves overall codebase code coverage.
  • Changes are added to the CHANGELOG. See the docs for information about adding to the changelog.

@duckontheweb duckontheweb requested a review from lossyrob July 17, 2021 03:01
@codecov-commenter
Copy link

codecov-commenter commented Jul 17, 2021

Codecov Report

Merging #564 (bb5042c) into main (e45af8e) will increase coverage by 0.14%.
The diff coverage is 95.83%.

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #564      +/-   ##
==========================================
+ Coverage   94.54%   94.69%   +0.14%     
==========================================
  Files          71       72       +1     
  Lines       10707    10755      +48     
  Branches     1067     1068       +1     
==========================================
+ Hits        10123    10184      +61     
+ Misses        412      395      -17     
- Partials      172      176       +4     
Impacted Files Coverage Δ
pystac/extensions/item_assets.py 84.09% <71.42%> (+17.42%) ⬆️
tests/extensions/test_item_assets.py 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e45af8e...bb5042c. Read the comment docs.

@duckontheweb duckontheweb added this to the 1.0.0 milestone Jul 17, 2021
@duckontheweb duckontheweb merged commit 3dff1b6 into stac-utils:main Jul 17, 2021
@duckontheweb duckontheweb deleted the update/item-assets-extension branch July 17, 2021 15:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Testing and documentation for item-assets extension
3 participants