-
Notifications
You must be signed in to change notification settings - Fork 122
Use extension-like API for CommonMetadata #563
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Use extension-like API for CommonMetadata #563
Conversation
Codecov Report
@@ Coverage Diff @@
## main #563 +/- ##
==========================================
- Coverage 94.69% 94.66% -0.03%
==========================================
Files 72 75 +3
Lines 10755 10722 -33
Branches 1068 1048 -20
==========================================
- Hits 10184 10150 -34
- Misses 395 396 +1
Partials 176 176
Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
A suggestion about TYPE_CHECKING import aliasing but otherwise LGTM
0f010ea
to
aae4617
Compare
aae4617
to
5a72a2a
Compare
Related Issue(s):
Description:
CommonMetadata
andProvider
to their own modulesProvider
objectsCommonMetadata
to use similar API toPropertyExtension
Asset.common_metadata
propertyTODO:
PR Checklist:
pre-commit run --all-files
)scripts/test
)