Return calling class from Link constructor methods #512
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related Issue(s):
Description:
Following in the footsteps of #451, this changes the Link constructor methods (
Link.from_dict
, etc.) to return the calling class instead of hard-coding theLink
class as the return type. This allows downstream libraries and users to sub-classLink
and still be able to use these constructors.UPDATE: Also does the same for
Asset
constructors and forclone
methods onCatalog
,Collection
,Item
,Link
, andAsset
classes.PR Checklist:
pre-commit run --all-files
)scripts/test
)