Skip to content

RFC: Drop support for Python 3.6 #500

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Jul 7, 2021

Conversation

duckontheweb
Copy link
Contributor

@duckontheweb duckontheweb commented Jun 29, 2021

Related Issue(s):

Description:

Drops support for Python 3.6 (both in terms of python_version check on install and in CI tests), and adds a note to the README that we follow the NEP-29 guidelines.

PR Checklist:

  • Code is formatted (run pre-commit run --all-files)
  • Tests pass (run scripts/test)
  • Documentation has been updated to reflect changes, if applicable
  • This PR maintains or improves overall codebase code coverage.
  • Changes are added to the CHANGELOG. See the docs for information about adding to the changelog.

@duckontheweb
Copy link
Contributor Author

@lossyrob
Copy link
Member

I believe @schwehr is still stuck on 3.6. I'd rather not remove 3.6 if that will be really disruptive to his usage of PySTAC as I believe he is a big user and has been a great contributor to the project. If that's not the case, I'm +1.

@schwehr
Copy link
Collaborator

schwehr commented Jun 30, 2021

Am in the process of going py 3.6 to 3.7. Go for it. +1 for dropping 3.6. Thanks for asking me!

@duckontheweb duckontheweb marked this pull request as ready for review June 30, 2021 14:50
PySTAC is a library for working with [SpatialTemporal Asset Catalog](https://stacspec.org) in Python 3.
PySTAC is a library for working with [SpatioTemporal Asset Catalog](https://stacspec.org) in Python 3.
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just a note that I also fixed this as part of this PR.

@codecov-commenter
Copy link

Codecov Report

Merging #500 (c6bf951) into main (c0f0b6d) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##             main     #500   +/-   ##
=======================================
  Coverage   95.43%   95.43%           
=======================================
  Files          71       71           
  Lines        9978     9978           
=======================================
  Hits         9523     9523           
  Misses        455      455           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c0f0b6d...c6bf951. Read the comment docs.

@duckontheweb duckontheweb merged commit 664020e into stac-utils:main Jul 7, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Deprecating support for older Python 3 versions
5 participants