Skip to content

Create CODE_OF_CONDUCT.md #399

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 9 commits into from
Jun 10, 2021
Merged

Conversation

BobinMathew
Copy link
Contributor

@BobinMathew BobinMathew commented Jun 2, 2021

Related Issue(s): #
Issue #385

Description:
Created a CODE_OF_CONDUCT.md that points to Code of Conduct in the STAC spec repo. This makes the code of conduct consistent with the STAC repo's code of conduct

PR Checklist:

  • Code is formatted (run scripts/format)
  • Tests pass (run scripts/test)
  • This PR maintains or improves overall codebase code coverage.
  • Changes are added to the CHANGELOG. See the docs for information about adding to the changelog.

@codecov-commenter
Copy link

codecov-commenter commented Jun 2, 2021

Codecov Report

Merging #399 (bc37c34) into main (3f2f95f) will decrease coverage by 0.06%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #399      +/-   ##
==========================================
- Coverage   89.71%   89.64%   -0.07%     
==========================================
  Files          39       39              
  Lines        5154     5169      +15     
==========================================
+ Hits         4624     4634      +10     
- Misses        530      535       +5     
Impacted Files Coverage Δ
pystac/stac_io.py 72.46% <0.00%> (-0.68%) ⬇️
pystac/item.py 96.67% <0.00%> (-0.56%) ⬇️
pystac/summaries.py 78.20% <0.00%> (ø)
pystac/stac_object.py 95.08% <0.00%> (ø)
pystac/extensions/label.py 85.89% <0.00%> (ø)
pystac/validation/stac_validator.py 87.35% <0.00%> (ø)
pystac/utils.py 97.02% <0.00%> (+0.06%) ⬆️
pystac/extensions/datacube.py 57.03% <0.00%> (+1.16%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 3f2f95f...bc37c34. Read the comment docs.

Copy link
Contributor

@duckontheweb duckontheweb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for contributing this @BobinMathew, and for recognizing the gap.

I think it might be good to at least include the Our Pledge portion of the Code of Conduct in full in this document and then reference the STAC Code of Conduct for details on the specific standards. It seems important to make a clear statement in this repo about the kind of environment that are hoping to foster so that newcomers know it's something that's important within the community.

Also, the STAC spec Code of Conduct lists stac-spec-admins@googlegroups.com as the contact to report abuses and unacceptable behavior. Do we need a different email, or can we use that one here (@cholmes)?

BobinMathew and others added 2 commits June 4, 2021 19:21
Co-authored-by: Pete Gadomski <pete.gadomski@gmail.com>
@BobinMathew
Copy link
Contributor Author

  • Included Pledge
  • contact details pending...

@duckontheweb
Copy link
Contributor

@BobinMathew We are going to use the STAC Project Steering Committee email (stac-psc@radiant.earth) as our point of contact. It sounds like the stac-spec repo may also update their Code of Conduct to use this email at some point.

I think it would be good to include that information in this repo as well to make it as easy as possible for someone to report a violation or other problem.

Added contact details
@BobinMathew
Copy link
Contributor Author

  • Included Pledge
  • contact details added

@duckontheweb duckontheweb requested review from cholmes and lossyrob June 7, 2021 13:10
Copy link
Contributor

@duckontheweb duckontheweb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good to me, thanks for contributing this @BobinMathew!

I'd like to get approval from at least @cholmes and @lossyrob as well and give other folks a chance to comment if they'd like.

Copy link
Member

@lossyrob lossyrob left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Made some suggestions for small changes

BobinMathew and others added 3 commits June 7, 2021 19:50
Co-authored-by: Rob Emanuele <rdemanuele@gmail.com>
Co-authored-by: Rob Emanuele <rdemanuele@gmail.com>
Co-authored-by: Rob Emanuele <rdemanuele@gmail.com>
@BobinMathew
Copy link
Contributor Author

Thanks everyone 😀

@duckontheweb duckontheweb added this to the 1.0.0-rc.1 milestone Jun 9, 2021
@duckontheweb duckontheweb merged commit 8946c9b into stac-utils:main Jun 10, 2021
@duckontheweb
Copy link
Contributor

Thanks again for the contribution @BobinMathew!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants