Skip to content

Fix collection assets #373

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Jun 1, 2021
Merged

Fix collection assets #373

merged 3 commits into from
Jun 1, 2021

Conversation

gadomski
Copy link
Member

Related Issue(s): None

Description: Fixes collection assets. Tests do not pass because the following files have assets without hrefs (which were required in v0.6.0):

  • tests/data-files/examples/sentinel-0.6.0/sentinel-2-l1c/catalog.json
  • tests/data-files/examples/landsat-0.6.0/156/catalog.json
  • tests/data-files/examples/landsat-0.6.0/010/catalog.json

I see two mitigation options:

  1. Remove these files from the test suite as they are invalid per the spec, or
  2. Add migration logic to drop assets w/o hrefs here

Thoughts?

PR Checklist:

  • Code is formatted (run scripts/format)
  • Tests pass (run scripts/test)
  • This PR maintains or improves overall codebase code coverage.
  • Changes are added to the CHANGELOG. See the docs for information about adding to the changelog.

@gadomski gadomski mentioned this pull request Jun 1, 2021
Closed
@duckontheweb
Copy link
Contributor

I see two mitigation options:

  1. Remove these files from the test suite as they are invalid per the spec, or
  2. Add migration logic to drop assets w/o hrefs here

My vote would be for removing these files since we only advertise support for STAC >= v0.8.* here.

duckontheweb
duckontheweb approved these changes Jun 1, 2021
View reviewed changes
Copy link
Contributor

@duckontheweb duckontheweb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@duckontheweb duckontheweb mentioned this pull request Jun 1, 2021
Closed
4 tasks
@TomAugspurger
Copy link
Collaborator

This also closes #373.

gadomski added 3 commits June 1, 2021 11:47
@gadomski
Fix collection assets
a87c06e 
Assets were being created with the href set to the entire asset
dictionary.
@gadomski
Remove some v0.6.0 examples from testing
973c3d2 
Per
#373 (comment), we
don't explicitly support v0.6.0 STAC, and these two examples were
breaking tests.
@gadomski
Update changelog for #373
f2f0678
@duckontheweb duckontheweb merged commit c2b7e0e into stac-utils:main Jun 1, 2021
@gadomski gadomski deleted the fix/collection-assets branch June 1, 2021 17:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@duckontheweb duckontheweb duckontheweb approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@gadomski @duckontheweb @TomAugspurger