Set self href on items and children when adding #294
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related Issue(s): #
#284
Description:
When an existing catalog and an item or child is added to it, the self_href was not set which meant that they had to either be set manually, or a call to
normalize_hrefs
would be needed. This would also happen ifgenerate_subcatalogs
was used....all the subcatalogs and items added will need to be normalized.However, since the catalog already exists, this should be unnecessary. Given a layout strategy, a self href can be determined and set, if the parent has a self href.
Note the only case where a parent does not have a self href is when the catalog is first created in memory and has not yet been saved. In that case a call to
normalize
is neededPR Checklist:
scripts/format
)scripts/test
)