Modify Item set_self_href to ensure asset HREFs do not break. #226
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Previous to this change, using set_self_href on Item could cause assets with relative HREFs to lose a pointer to the actual asset files. This was not true in the case of using nomralize_hrefs on a catalog containing the item, but calling set_self_href directly on the item could cause this problem to occur. This change moves the logic to ensure relative asset HREFs do not break when changing the Item's HREF into an overridden version of set_self_href on Item.
Codecov Report
@@ Coverage Diff @@
## develop #226 +/- ##
========================================
Coverage 93.23% 93.24%
========================================
Files 29 29
Lines 3578 3581 +3
========================================
+ Hits 3336 3339 +3
Misses 242 242
Continue to review full report at Codecov.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previous to this change, using set_self_href on Item could cause assets with relative HREFs to lose a pointer to the actual asset files. This was not true in the case of using normalize_hrefs on a catalog containing the item, but calling set_self_href directly on the item could cause this problem to occur. This change moves the logic to ensure relative asset HREFs do not break when changing the Item's HREF into an overridden version of set_self_href on Item.