Skip to content

Asset file path #7

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 5 commits into from
Sep 24, 2021
Merged

Asset file path #7

merged 5 commits into from
Sep 24, 2021

Conversation

emmanuelmathot
Copy link
Member

@emmanuelmathot emmanuelmathot commented Jul 6, 2021

Context

When downloading assets locally to run some software (e.g. ESA SNAP on S2), it expects the file organized as originally in the SAFE manifest. Assets may be distributed in the cloud and have lost this organizational information in its own url.

Proposed Solution

  • file:path field to indicate a relative path that may be used to organize files as expected.

@emmanuelmathot emmanuelmathot requested review from m-mohr and cholmes July 6, 2021 11:09
@m-mohr
Copy link
Contributor

m-mohr commented Jul 6, 2021

Hmm, I'm thinking whether alignment with radiantearth/stac-spec#956 would help, specifically what I call archive:href there?

@emmanuelmathot
Copy link
Member Author

I see the point with the discussion. What is an archive? Only a compressed files container or we consider the a whole set of files?
My proposal here is mainly focused on the file itself and where it stands in a file system.

@m-mohr
Copy link
Contributor

m-mohr commented Jul 26, 2021

Sorry for the slow response.

Usually a container for files, e.g. ZIP, TAR, etc. In them, there's usually also a pre-defined path where to store the file after extraction. I'd also be fine to just re-use file:path in archive if that's the best solution, but it should be unambiguous. It feels like they serve the same or a very similar purpose, but maybe they are not?

@emmanuelmathot
Copy link
Member Author

It serves the same purpose with a scope larger than only archive files.

@m-mohr
Copy link
Contributor

m-mohr commented Jul 27, 2021

So I guess then we should use file:path and define it in a way that it works for both use cases and then archive can re-use this.

@emmanuelmathot
Copy link
Member Author

So I guess then we should use file:path and define it in a way that it works for both use cases and then archive can re-use this.

Agreed

@emmanuelmathot
Copy link
Member Author

@m-mohr any progress on this PR? Is the file:path definition good for being used in the archive extension as well?

@emmanuelmathot emmanuelmathot changed the title Relative path Asset file path Sep 8, 2021
@m-mohr
Copy link
Contributor

m-mohr commented Sep 8, 2021

Oh, I thought you would propose a more generic description and I guess you thought I'd do it? Sorry about that.

Unfortunately, I'm on vacation soon so I could only propose something after that, but I think the name and schema are fine, we just need to tweak the description a bit. So you can start using it and we'll just merge and release it later. I can probably finish this in early October together with the archive extension.

@m-mohr m-mohr self-assigned this Sep 8, 2021
@emmanuelmathot
Copy link
Member Author

@m-mohr is it ok with local_path ?

@emmanuelmathot emmanuelmathot merged commit 48272e0 into main Sep 24, 2021
@emmanuelmathot emmanuelmathot deleted the path branch September 24, 2021 08:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants