Skip to content

websocket-sharp\Net\CookieException.cs(10,10): Error CS0540: 'WebSocketSharp.Net.CookieException.ISerializable.GetObjectData(System.Runtime.Serialization.SerializationInfo, System.Runtime.Serialization.StreamingContext)': containing type does not implement interface 'System.Runtime.Serialization.ISerializable' (CS0540) (websocket-sharp)  #544

Open
@The-MAZZTer

Description

@The-MAZZTer

Build error in r3427. Occurs when building for Release in VS2017 and MonoDevelop.

Inheritance from ISerializable seems to have been removed in r3410 (r3409 builds properly).

Commit log does not reveal what the intent was but I suspect the implemented functions should have been removed.

Removing the explicitly implemented functions allows the build to complete successfully in r3427 (but I am not sure if this is the correct fix).

Index: websocket-sharp/Net/CookieException.cs
===================================================================
--- websocket-sharp/Net/CookieException.cs      (revision 3409)
+++ websocket-sharp/Net/CookieException.cs      (revision 3410)
@@ -46,7 +46,7 @@
   /// The exception that is thrown when a <see cref="Cookie"/> gets an error.
   /// </summary>
   [Serializable]
-  public class CookieException : FormatException, ISerializable
+  public class CookieException : FormatException
   {
     #region Internal Constructors


Property changes on: websocket-sharp/Net/CookieException.cs
___________________________________________________________________

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions