feat: Add Tags to Photo entity (opt-in via PhotoSearchExtras.Tags) - #150
Merged
Conversation
Owner
|
LGTM! |
st0o0
approved these changes
Aug 11, 2026
Contributor
Author
|
@LineOfC0d3 Any chance to have this merged and published as a new nuget-version? Thanks :-) |
st0o0
force-pushed
the
feature/add-tags-to-photo
branch
from
August 14, 2026 14:31
3b28181 to
f03a37d
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Add a nullable
Tagsproperty to thePhotoentity, mapped to the Flickr APItagsfield.Background
Flickr's
flickr.photos.searchresponse includes a space-delimitedtagsfield when the caller'sextrasincludesPhotoSearchExtras.Tags. The library already has thePhotoSearchExtras.Tagsflag, but thePhotorecord never maps the returnedtagsfield — so it's silently dropped during deserialization.This follows the exact same pattern and precedent as the previously merged
Descriptionaddition (commit5f2a23aac1ed112aec1b0aa0df7e5b980e37dd0e): a new nullable property mapped to a Flickr API field that is only present in the response when its correspondingPhotoSearchExtrasflag is requested.Changes
src/Flickr.Net/Entities/Photo.cs: AddedTagsproperty (string?,[JsonPropertyName("tags")])src/Flickr.Net.Test/Entities/PhotoTests.cs: AddedPhotoTagsAreDeserializedandPhotoTagsIsNullWhenNotPresenttests, following the existingPhotoDescription*test patternCompatibility
Fully backward compatible:
nullPhotoSearchExtras.Tagsin their extrasTest results
All 88 tests pass (86 existing + 2 new).