Skip to content

feat: Add Tags to Photo entity (opt-in via PhotoSearchExtras.Tags) - #150

Merged
st0o0 merged 1 commit into
st0o0:mainfrom
toralux:feature/add-tags-to-photo
Aug 14, 2026
Merged

feat: Add Tags to Photo entity (opt-in via PhotoSearchExtras.Tags)#150
st0o0 merged 1 commit into
st0o0:mainfrom
toralux:feature/add-tags-to-photo

Conversation

@toralux

@toralux toralux commented Aug 11, 2026

Copy link
Copy Markdown
Contributor

Summary

Add a nullable Tags property to the Photo entity, mapped to the Flickr API tags field.

Background

Flickr's flickr.photos.search response includes a space-delimited tags field when the caller's extras includes PhotoSearchExtras.Tags. The library already has the PhotoSearchExtras.Tags flag, but the Photo record never maps the returned tags field — so it's silently dropped during deserialization.

This follows the exact same pattern and precedent as the previously merged Description addition (commit 5f2a23aac1ed112aec1b0aa0df7e5b980e37dd0e): a new nullable property mapped to a Flickr API field that is only present in the response when its corresponding PhotoSearchExtras flag is requested.

Changes

  • src/Flickr.Net/Entities/Photo.cs: Added Tags property (string?, [JsonPropertyName("tags")])
  • src/Flickr.Net.Test/Entities/PhotoTests.cs: Added PhotoTagsAreDeserialized and PhotoTagsIsNullWhenNotPresent tests, following the existing PhotoDescription* test pattern

Compatibility

Fully backward compatible:

  • The property is nullable and defaults to null
  • No payload or behavior change for callers who don't include PhotoSearchExtras.Tags in their extras
  • No breaking changes to existing API surface

Test results

All 88 tests pass (86 existing + 2 new).

@st0o0

st0o0 commented Aug 11, 2026

Copy link
Copy Markdown
Owner

LGTM!

@toralux

toralux commented Aug 12, 2026

Copy link
Copy Markdown
Contributor Author

@LineOfC0d3 Any chance to have this merged and published as a new nuget-version? Thanks :-)

@st0o0
st0o0 force-pushed the feature/add-tags-to-photo branch from 3b28181 to f03a37d Compare August 14, 2026 14:31
@st0o0
st0o0 merged commit e00d3d4 into st0o0:main Aug 14, 2026
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants