-
Notifications
You must be signed in to change notification settings - Fork 15
Print rspec progress to standard out when using 'run in terminal' #73
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
73c5245
to
2524413
Compare
Looks like we may need a tapioca bump to resolve the failing typecheck stage: #65 (comment) |
spent an hour debugging the same issue. Would be great to release the fix. Thank you! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks!
Typechecking would require both Tapioca bump and Sorbet's support to type aliasing in RBS, which is currently a WIP. I will deal with those later.
Sadly, this doesn't seem to be working with the ruby-lsp option to use a custom gemfile. I'm not holding my breath since the setup is less conventional, but if anyone has an idea on how to fix that. I'm running a separate gemfile just for
I understand that the loading doesn't happen from this bundle and thus it doesn't work. I get an error similar to this one. Sorry for the messy stacktrace, it looks like the load error cascade to other errors later on. Stacktrace
|
Recent changes to support Ruby LSP’s full test discovery features introduced a new formatter class used in RSpec commands:
https://github.com/st0012/ruby-lsp-rspec/pull/62/files#diff-e8b1addcbd65ede3ce4d3037be8580740eca961b01ba9c19c2989e4f681ea400
This new formatter no longer prints RSpec progress and output to stdout, which reduces the usefulness of the “Run in terminal” command.
This PR addresses the issue by making the RSpecFormatter class a subclass of ::RSpec::Core::Formatters::ProgressFormatter. This change retains the message passing of the new formatter while also restoring progress and output printing.