Fix SpecStyle to not receive Prism events #71
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The parent class TestDiscovery also registers SpecStyle for Prism event. While handling the events it tries to access a nil variable when entering a class or module and thus completely break code analysis of normal ruby files.
st0012
reviewed
May 31, 2025
|
I added a test case to verify that the patch effectively disables initialization of the SpecStyle |
|
Sorry, I mean is it possible to add an integration test like other specs in this project that can reproduce the issue? Or a test setup that can reproduce the error you mentioned would help too. |
|
That would effectively be feeding the ruby-lsp (with the patched SpecStyle) a ruby source file which contains a module and class block. Without the fixed code it should fail, with the fixed code it would pass. |
The improperly patched SpecStyle would fail when the Ruby LSP was handling a 'textDocument/foldingRange' message (probably others too) for a source while with module and class blocks as it was still receiving events from Prism (which we do not want) for the RSpec addon.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Calling super will still register for events. The parent class TestDiscovery also registers SpecStyle for Prism event. While handling the events it tries to access a nil variable when entering a class or module and thus completely break code analysis of normal ruby files.