Skip to content
This repository has been archived by the owner on Aug 10, 2023. It is now read-only.

Improve the solutions module #312

Merged
merged 3 commits into from
Aug 13, 2019
Merged

Improve the solutions module #312

merged 3 commits into from
Aug 13, 2019

Conversation

PhilippMatthes
Copy link
Collaborator

@PhilippMatthes PhilippMatthes commented Aug 9, 2019

Fixes: #308, #309, #310, #311.

See the meta issue #311:

@PhilippMatthes PhilippMatthes added the enhancement New feature or request label Aug 9, 2019
@PhilippMatthes PhilippMatthes self-assigned this Aug 9, 2019
Copy link
Contributor

@martinmo martinmo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@PhilippMatthes PhilippMatthes force-pushed the 311-improve-solutions-module branch 2 times, most recently from dc24e17 to 08f6c47 Compare August 9, 2019 11:58
@PhilippMatthes PhilippMatthes dismissed martinmo’s stale review August 9, 2019 12:01

Changes were separated into 3 unique commits. Changes to the solution archive download view were reverted, but the corresponding test was corrected, so that it looks for a 404 on access violation.

tests/solutions/test_models.py Outdated Show resolved Hide resolved
tests/solutions/test_models.py Outdated Show resolved Hide resolved
@PhilippMatthes PhilippMatthes dismissed martinmo’s stale review August 13, 2019 08:36

I replaced the calls as proposed and also removed the todo, as it was no longer applicable.

@martinmo martinmo force-pushed the 311-improve-solutions-module branch from 8273efd to 6a9c54a Compare August 13, 2019 08:53
@martinmo martinmo merged commit 6a9c54a into master Aug 13, 2019
@martinmo martinmo deleted the 311-improve-solutions-module branch August 13, 2019 08:57
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Raise PermissionDenied if user tries to download another user's solution
2 participants