Skip to content

Add from_encoding:UTF-8 to examples/log-collection/fluentd/fluent.conf #28

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Jan 20, 2022
Merged

Add from_encoding:UTF-8 to examples/log-collection/fluentd/fluent.conf #28

merged 2 commits into from
Jan 20, 2022

Conversation

tippy3
Copy link
Contributor

@tippy3 tippy3 commented Jan 18, 2022 •
edited
Loading

Add from_encoding UTF-8 to examples/log-collection/fluentd/fluent.conf

  • in_tail plugin has from_encoding option. This is different from enconding.
  • Now only encoding UTF-8 is set in in_tail.
  • This means Input is ASCII-8BIT and output is UTF-8, not Both are UTF-8.
  • In order to make it easier to understand, add from_encoding UTF-8

I want to use fluentd image that has this fluent.conf. Could you release v0.0.3?

@tippy3 tippy3 requested review from 2kyym and banatt January 18, 2022 07:56
yokawasa
yokawasa reviewed Jan 18, 2022
View reviewed changes
@2kyym 2kyym requested a review from civitaspo January 18, 2022 09:06
yokawasa
yokawasa approved these changes Jan 18, 2022
View reviewed changes
Copy link
Contributor

@yokawasa yokawasa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm!

banatt
banatt approved these changes Jan 19, 2022
View reviewed changes
Copy link

@banatt banatt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

2kyym
2kyym approved these changes Jan 20, 2022
View reviewed changes
Copy link
Contributor

@2kyym 2kyym left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM :)

@tippy3 tippy3 merged commit 69f6137 into main Jan 20, 2022
@tippy3 tippy3 deleted the fix_exmaple_fluent-conf branch January 20, 2022 06:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@2kyym 2kyym 2kyym approved these changes

@banatt banatt banatt approved these changes

@civitaspo civitaspo Awaiting requested review from civitaspo

+1 more reviewer

@yokawasa yokawasa yokawasa approved these changes

Reviewers whose approvals may not affect merge requirements
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@tippy3 @yokawasa @2kyym @banatt