Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

support hyphenated nouns in lex #75

Closed
ssube opened this issue Dec 24, 2018 · 0 comments
Closed

support hyphenated nouns in lex #75

ssube opened this issue Dec 24, 2018 · 0 comments
Assignees
@ssube
Labels
scope/controller status/fixed issues that have been fixed and confirmed type/bug
Milestone
1.0 - stable

Comments

@ssube
Copy link
Owner

ssube commented Dec 24, 2018

Summary

Lex does not support hyphens in intent names, but the github-pull-request noun now uses them. To support this, after splitting the intent on _, apply kebabCase to the noun (already the conventional class-to-string naming conversion).

This will not change the existing time and weather nouns, and thus is not a breaking change. It will improve the model going forward.
@ssube ssube added this to the 1.0 - stable milestone Dec 24, 2018
@ssube ssube self-assigned this Dec 24, 2018
@ssube ssube added status/planned issues that have been planned but not started and removed status/new labels Dec 24, 2018
ssube added a commit that referenced this issue Dec 24, 2018
@ssube
fix: convert camel case lex intents to kebab case nouns (#75)
ca2e198
@ssube ssube mentioned this issue Dec 24, 2018
Merged
4 tasks
@ssube ssube added status/fixed issues that have been fixed and confirmed and removed status/planned issues that have been planned but not started labels Dec 24, 2018
@ssube ssube closed this as completed Dec 24, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@ssube ssube

Labels
scope/controller status/fixed issues that have been fixed and confirmed type/bug
Projects
None yet
Milestone
1.0 - stable
Development

No branches or pull requests
1 participant
@ssube