Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

include locale and schema yaml in bundle #396

Closed
ssube opened this issue Sep 8, 2019 · 1 comment
Closed

include locale and schema yaml in bundle #396

ssube opened this issue Sep 8, 2019 · 1 comment
Assignees
@ssube
Labels
scope/build size/small status/fixed issues that have been fixed and confirmed type/bug
Milestone
1.0 - stable

Comments

@ssube
Copy link
Owner

ssube commented Sep 8, 2019

Summary

The src/locale/*.yml and src/schema/schema.yml files should be included in out/main.js, but are not.

Steps to Reproduce

  • make

Actual Behavior

  • source of those files is not present

Expected Behavior

  • source of those files should be present as modules

Details

https://github.com/rollup/rollup-plugin-yaml should be able to handle this, but has not been updated recently. I've forked it with plans to update for the latest rollup:
https://github.com/ssube/rollup-plugin-yaml
@ssube ssube added this to the 1.0 - stable milestone Sep 8, 2019
@ssube ssube self-assigned this Sep 8, 2019
@ssube ssube mentioned this issue Sep 8, 2019
Merged
4 tasks
@ssube
Copy link
Owner Author

ssube commented Sep 27, 2019

This will happen as part of #470 once ssube/rollup-template#4 has been closed on that side.

ssube added a commit that referenced this issue Sep 28, 2019
@ssube
fix(build): include yml in bundle (fixes #396)
11d4422
ssube added a commit that referenced this issue Sep 30, 2019
@ssube
fix(build): include yml in bundle (fixes #396)
70b913b
@ssube ssube closed this as completed in 07217f5 Sep 30, 2019
@ssube ssube added status/fixed issues that have been fixed and confirmed and removed status/new labels Oct 4, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@ssube ssube

Labels
scope/build size/small status/fixed issues that have been fixed and confirmed type/bug
Projects
None yet
Milestone
1.0 - stable
Development

No branches or pull requests
1 participant
@ssube