Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

switch to github rest client #133

Closed
2 of 3 tasks
ssube opened this issue Jan 14, 2019 · 0 comments
Closed
2 of 3 tasks

switch to github rest client #133

ssube opened this issue Jan 14, 2019 · 0 comments
Assignees
@ssube
Labels
scope/controller scope/listener status/fixed issues that have been fixed and confirmed type/deps type/feature
Milestone
1.0 - stable

Comments

@ssube
Copy link
Owner

ssube commented Jan 14, 2019 •
edited
Loading

Summary

The Github GraphQL API is incomplete. PRs are experimental, notifications missing entirely (for years: https://platform.github.community/t/notifications-and-events-apis-seem-to-be-missing/3114/8), and pagination is a mess.
With the recent change to remove data, the GraphQL API is not even stable. Between the two, it is absolutely useless for the bot. Replace octokit/graphql with octokit/rest so that basic API features are available.

Scope

  • replace octokit/graphql dep with octokit/rest
  • fix github PR ctrl
  • add github comment listener
@ssube ssube added this to the 1.0 - stable milestone Jan 14, 2019
@ssube ssube self-assigned this Jan 14, 2019
ssube added a commit that referenced this issue Jan 16, 2019
@ssube
fix: swap octokit graphql for rest (#133)
1915492
@ssube ssube mentioned this issue Jan 16, 2019
Merged
3 tasks
@ssube ssube added status/fixed issues that have been fixed and confirmed and removed status/new status/progress issues that are in progress labels Jan 16, 2019
@ssube ssube closed this as completed Jan 16, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@ssube ssube

Labels
scope/controller scope/listener status/fixed issues that have been fixed and confirmed type/deps type/feature
Projects
None yet
Milestone
1.0 - stable
Development

No branches or pull requests
1 participant
@ssube