fix(schema): make redirect defaults/forces fields required

BREAKING CHANGE: service redirect must have both the `defaults` and
`forces` top-level keys, which may be empty. `redirect: {}` should
be replaced with `redirect: {defaults: {}, forces: {}}`.

docs/controller/account-controller.yml

@@ -10,7 +10,9 @@ data:
       - session:create
     roles:
       - user
-  redirect: {}
+  redirect:
+    defaults: {}
+    forces: {}
   root:
     allow: true
     name: root

docs/controller/bot-controller.yml

@@ -3,7 +3,9 @@ metadata:
   name: default-bot
 data:
   filters: []
-  redirect: {}
+  redirect:
+    defaults: {}
+    forces: {}
   transforms:
     - metadata:
         kind: template-transform

docs/controller/command-controller.yml

@@ -7,4 +7,6 @@ data:
     labels: {}
     noun: echo
     verb: create
-  redirect: {}
+  redirect:
+    defaults: {}
+    forces: {}

docs/controller/completion-controller.yml

@@ -3,6 +3,7 @@ metadata:
   name: default-completion
 data:
   redirect:
+    defaults: {}
     forces:
       target:
         source: false

docs/controller/dice-controller.yml

@@ -2,4 +2,6 @@ metadata:
   kind: dice-controller
   name: test-dice
 data:
-  redirect: {}
+  redirect:
+    defaults: {}
+    forces: {}

docs/controller/echo-controller.yml

@@ -3,6 +3,7 @@ metadata:
   name: test-echo-controller
 data:
   redirect:
+    defaults: {}
     forces:
       target:
         source: false

docs/controller/learn-controller.yml

@@ -8,4 +8,6 @@ data:
       - time
       - weather
     mode: include
-  redirect: {}
+  redirect:
+    defaults: {}
+    forces: {}

docs/controller/math-controller.yml

@@ -16,4 +16,6 @@ data:
   math:
     matrix: Array
     number: number
-  redirect: {}
+  redirect:
+    defaults: {}
+    forces: {}

docs/controller/random-controller.yml

@@ -2,4 +2,6 @@ metadata:
   kind: random-controller
   name: test-random
 data:
-  redirect: {}
+  redirect:
+    defaults: {}
+    forces: {}

docs/controller/reaction-controller.yml

@@ -11,4 +11,6 @@ data:
             values:
               - regexp: !regexp /maple/
       add: [":maple_leaf:"]
-  redirect: {}
+  redirect:
+    defaults: {}
+    forces: {}

docs/controller/search-controller-mdn.yml

@@ -4,7 +4,9 @@ metadata:
 data:
   count: 3
   field: args
-  redirect: {}
+  redirect:
+    defaults: {}
+    forces: {}
   request:
     method: GET
     url: https://developer.mozilla.org/en-US/search.json?q={{ data }}

docs/controller/sed-controller.yml

@@ -2,4 +2,6 @@ metadata:
   kind: sed-controller
   name: test-sed
 data:
-  redirect: {}
+  redirect:
+    defaults: {}
+    forces: {}

docs/controller/time-controller.yml

@@ -3,5 +3,7 @@ metadata:
   name: test-time
 data:
   locale: en-US
-  redirect: {}
+  redirect:
+    defaults: {}
+    forces: {}
   zone: America/Chicago

docs/controller/token-controller.yml

@@ -2,7 +2,9 @@ metadata:
   kind: token-controller
   name: default-token
 data:
-  redirect: {}
+  redirect:
+    defaults: {}
+    forces: {}
   # nothing about these token settings is secure and they should not be used in production
   token:
     audience: [test-audience]

docs/controller/user-controller.yml

@@ -2,4 +2,6 @@ metadata:
   kind: user-controller
   name: default-user
 data:
-  redirect: {}
+  redirect:
+    defaults: {}
+    forces: {}

docs/controller/weather-controller-owm.yml

@@ -5,7 +5,9 @@ data:
   api:
     key: !env ISOLEX_WEATHER_API_KEY
     root: https://api.openweathermap.org/data/2.5/
-  redirect: {}
+  redirect:
+    defaults: {}
+    forces: {}
   transforms:
     - metadata:
         kind: template-transform

docs/generator/command-generator.yml

@@ -18,4 +18,5 @@ data:
         source: false
         service:
           kind: discord-listener
-          name: test-discord
+          name: test-discord
+    forces: {}

docs/generator/cron-generator.yml

@@ -16,5 +16,6 @@ data:
         service: &target
           kind: discord-listener
           name: test-discord
+    forces: {}
   services:
     - *target

docs/generator/event-generator.yml

@@ -16,5 +16,6 @@ data:
         service: &discord-metadata
           kind: discord-listener
           name: test-discord
+    forces: {}
   services:
     - *discord-metadata

docs/generator/github-listener-generator.yml

@@ -16,5 +16,6 @@ data:
         service: &github-metadata
           kind: github-listener
           name: test-github
+    forces: {}
   services:
     - *github-metadata

docs/generator/message-generator.yml

@@ -19,6 +19,7 @@ data:
         service:
           kind: discord-listener
           name: test-discord
+    forces: {}
   transforms:
     - metadata:
         kind: template-transform

docs/generator/metrics-generator.yml

@@ -16,4 +16,5 @@ data:
         service:
           kind: discord-listener
           name: test-discord
+    forces: {}
   timeout: 100ms

docs/listener/express-listener.yml

@@ -27,6 +27,7 @@ data:
         service:
           kind: discord-listener
           name: test-discord
+    forces: {}
   token:
     audience: test-audience
     issuer: !env ISOLEX_TOKEN_ISSUER

src/controller/BaseController.ts

@@ -169,6 +169,11 @@ export abstract class BaseController<TData extends ControllerData> extends BotSe
   }
 
   protected async reply(baseCtx: Context, body: string): Promise<void> {
+    this.logger.debug({
+      original: baseCtx,
+      redirect: this.data.redirect,
+    }, 'preparing context redirect');
+
     const context = redirectContext(baseCtx, this.data.redirect, this.services);
     const msg = new Message({
       body,

src/schema/schema.yml

@@ -150,6 +150,9 @@ definitions:
   entity-context-redirect:
     type: object
     additionalProperties: false
+    required:
+      - defaults
+      - forces
     properties:
       defaults:
         allOf: