fix(config): update lint to naming-convention rule

config/eslint.json

@@ -35,7 +35,6 @@
                 }
             }
         ],
-        "@typescript-eslint/class-name-casing": "error",
         "@typescript-eslint/consistent-type-assertions": "error",
         "@typescript-eslint/consistent-type-definitions": "error",
         "@typescript-eslint/explicit-member-accessibility": [
@@ -61,7 +60,6 @@
                 "SwitchCase": 1
             }
         ],
-        "@typescript-eslint/interface-name-prefix": "error",
         "@typescript-eslint/member-delimiter-style": [
             "error",
             {
@@ -89,6 +87,60 @@
                 ]
             }
         ],
+        "@typescript-eslint/naming-convention": [
+            "error",
+            {
+                "selector": "default",
+                "format": [
+                    "camelCase"
+                ],
+                "leadingUnderscore": "forbid",
+                "trailingUnderscore": "forbid"
+            },
+            {
+                "selector": "variable",
+                "format": [
+                    "camelCase",
+                    "UPPER_CASE"
+                ],
+                "leadingUnderscore": "forbid",
+                "trailingUnderscore": "forbid"
+            },
+            {
+                "selector": "typeLike",
+                "format": [
+                    "PascalCase"
+                ],
+                "leadingUnderscore": "forbid",
+                "trailingUnderscore": "forbid"
+            },
+            {
+                "selector": "interface",
+                "format": [
+                    "PascalCase"
+                ],
+                "leadingUnderscore": "forbid",
+                "trailingUnderscore": "forbid"
+            },
+            {
+                "selector": "function",
+                "format": [
+                    "camelCase",
+                    "PascalCase"
+                ],
+                "leadingUnderscore": "forbid",
+                "trailingUnderscore": "forbid"
+            },
+            {
+                "selector": "enumMember",
+                "format": [
+                    "PascalCase",
+		    "UPPER_CASE"
+                ],
+                "leadingUnderscore": "forbid",
+                "trailingUnderscore": "forbid"
+            }
+        ],
         "@typescript-eslint/no-empty-function": "error",
         "@typescript-eslint/no-empty-interface": "error",
         "@typescript-eslint/no-explicit-any": "error",
@@ -386,4 +438,4 @@
             }
         ]
     }
-}
+}

src/controller/BaseController.ts

@@ -13,7 +13,7 @@ import { Listener } from '../listener';
 import { Locale, TranslateOptions } from '../locale';
 import { ServiceModule } from '../module/ServiceModule';
 import { ServiceDefinition } from '../Service';
-import { applyTransforms, extractBody, Transform, TransformData } from '../transform';
+import { applyTransforms, extractBody, Transform, TransformData, TransformInput } from '../transform';
 import { TYPE_JSON, TYPE_TEXT } from '../utils/Mime';
 
 export type HandlerMethod = (this: BaseController<ControllerData>, cmd: Command, ctx: Context) => Promise<void>;
@@ -144,7 +144,7 @@ export abstract class BaseController<TData extends ControllerData> extends BotSe
     return false;
   }
 
-  protected async transformJSON(cmd: Command, data: object, ctx?: Context): Promise<void> {
+  protected async transformJSON(cmd: Command, data: TransformInput, ctx?: Context): Promise<void> {
     this.logger.debug({ data }, 'transforming json body');
 
     const result = await applyTransforms(this.transforms, cmd, TYPE_JSON, data);

src/controller/CommandController.ts

@@ -1,3 +1,5 @@
+import { makeDict } from '@apextoaster/js-utils';
+
 import { CheckRBAC, Controller, ControllerData, Handler } from '.';
 import { Command, CommandOptions, CommandVerb } from '../entity/Command';
 import { Context } from '../entity/Context';
@@ -19,7 +21,7 @@ export class CommandController extends BaseController<CommandControllerData> imp
   @Handler(NOUN_COMMAND, CommandVerb.Create)
   @CheckRBAC()
   public async createCommand(cmd: Command, ctx: Context): Promise<void> {
-    const data = await applyTransforms(this.transforms, cmd, TYPE_JSON, cmd.data);
+    const data = await applyTransforms(this.transforms, cmd, TYPE_JSON, makeDict(cmd.data));
     this.logger.debug({ data }, 'creating next command');
     const next = new Command({
       context: ctx,

src/controller/SearchController.ts

@@ -43,6 +43,7 @@ export class SearchController extends BaseController<SearchControllerData> imple
     const requestUrl = this.url.render({ data });
     this.logger.debug({ requestUrl }, 'searching at url');
 
+    /* eslint-disable-next-line @typescript-eslint/ban-types */
     const response: object = await this.request.create({
       json: true,
       method: this.data.request.method,

src/controller/WeatherController.ts

@@ -8,6 +8,8 @@ import { Context } from '../entity/Context';
 import { RequestFactory } from '../utils/Request';
 import { BaseController, BaseControllerOptions } from './BaseController';
 
+/* eslint-disable @typescript-eslint/naming-convention */
+
 export interface WeatherControllerData extends ControllerData {
   api: {
     key: string;

src/controller/github/PullController.ts

@@ -7,6 +7,8 @@ import { Context } from '../../entity/Context';
 import { GithubClient, GithubClientData } from '../../utils/github';
 import { BaseController, BaseControllerOptions, ErrorReplyType } from '../BaseController';
 
+/* eslint-disable @typescript-eslint/naming-convention */
+
 export const NOUN_PULL_REQUEST = 'github-pull-request';
 
 export interface GithubPullControllerData extends ControllerData {

src/controller/index.ts

@@ -60,6 +60,7 @@ export interface HandlerOptions {
   rbac?: RBACOptions;
 }
 
+/* eslint-disable-next-line @typescript-eslint/ban-types */
 export function getHandlerOptions(target: Function): HandlerOptions | undefined {
   if (!Reflect.hasMetadata(SYMBOL_HANDLER, target)) {
     return;

src/endpoint/GitlabEndpoint.ts

@@ -15,7 +15,8 @@ import { TemplateScope } from '../utils/Template';
 import { BaseEndpointOptions, STATUS_NOTFOUND, STATUS_SUCCESS } from './BaseEndpoint';
 import { HookEndpoint, HookEndpointData } from './HookEndpoint';
 
-/* eslint-disable @typescript-eslint/no-explicit-any, camelcase */
+/* eslint-disable @typescript-eslint/naming-convention, @typescript-eslint/no-explicit-any, camelcase */
+
 export interface GitlabBaseWebhook {
   object_kind: string;
 }

src/entity/Command.ts

@@ -40,6 +40,7 @@ export class Command extends BaseCommand implements CommandOptions {
     }
   }
 
+  /* eslint-disable-next-line @typescript-eslint/ban-types */
   public toJSON(): object {
     const result: Dict<unknown> = {
       data: Array.from(this.data),

src/entity/Context.ts

@@ -170,6 +170,7 @@ export class Context extends BaseEntity implements ContextOptions, ContextRoute
     }
   }
 
+  /* eslint-disable-next-line @typescript-eslint/ban-types */
   public toJSON(): object {
     return {
       channel: this.channel,

src/entity/Fragment.ts

@@ -51,7 +51,8 @@ export class Fragment extends BaseCommand implements FragmentOptions {
     }
   }
 
-  public toJSON() {
+  /* eslint-disable-next-line @typescript-eslint/ban-types */
+  public toJSON(): object {
     return {
       data: this.data,
       id: this.id,

src/entity/Message.ts

@@ -58,6 +58,7 @@ export class Message extends LabelEntity implements MessageEntityOptions {
     }
   }
 
+  /* eslint-disable-next-line @typescript-eslint/ban-types */
   public toJSON(): object {
     const context = doesExist(this.context) ? this.context.toJSON() : {};
     return {

src/entity/Tick.ts

@@ -35,6 +35,7 @@ export class Tick extends BaseEntity {
     }
   }
 
+  /* eslint-disable-next-line @typescript-eslint/ban-types */
   public toJSON(): object {
     return {
       createdAt: this.createdAt,

src/entity/auth/Token.ts

@@ -144,6 +144,7 @@ export class Token extends DataEntity<Array<string>> implements TokenOptions {
     });
   }
 
+  /* eslint-disable-next-line @typescript-eslint/ban-types */
   public toJSON(): object {
     return {
       audience: this.audience,

src/entity/auth/User.ts

@@ -71,6 +71,7 @@ export class User extends BaseEntity implements UserOptions {
     }
   }
 
+  /* eslint-disable-next-line @typescript-eslint/ban-types */
   public toJSON(): object {
     return {
       id: this.id,

src/entity/base/BaseCommand.ts

@@ -65,5 +65,6 @@ export abstract class BaseCommand extends DataEntity<CommandValue> {
     }
   }
 
+  /* eslint-disable-next-line @typescript-eslint/ban-types */
   public abstract toJSON(): object;
 }

src/entity/base/BaseEntity.ts

@@ -24,6 +24,7 @@ export abstract class BaseEntity implements BaseEntityOptions {
     }
   }
 
+  /* eslint-disable-next-line @typescript-eslint/ban-types */
   public abstract toJSON(): object;
 
   public toString(): string {

src/entity/base/DataEntity.ts

@@ -57,5 +57,6 @@ export abstract class DataEntity<TVal> extends LabelEntity {
     return getOrDefault(this.data, key, defaultValue);
   }
 
+  /* eslint-disable-next-line @typescript-eslint/ban-types */
   public abstract toJSON(): object;
 }

src/entity/base/LabelEntity.ts

@@ -35,5 +35,6 @@ export abstract class LabelEntity extends BaseEntity {
     this.labelStr = JSON.stringify(Array.from(this.labels));
   }
 
+  /* eslint-disable-next-line @typescript-eslint/ban-types */
   public abstract toJSON(): object;
 }

src/listener/ExpressListener.ts

@@ -95,6 +95,7 @@ export class ExpressListener extends SessionListener<ExpressListenerData> implem
     return [];
   }
 
+  /* eslint-disable-next-line @typescript-eslint/ban-types */
   public traceRequest(req: Request, res: Response, next: Function) {
     this.logger.debug({ req, res }, 'handling request');
     this.requestCounter.inc({

src/module/EntityModule.ts

@@ -19,6 +19,7 @@ export class EntityModule extends Module {
   }
 
   @Provides(INJECT_ENTITIES)
+  /* eslint-disable-next-line @typescript-eslint/ban-types */
   public async createEntities(): Promise<Array<Function>> {
     return [
       Command,

src/schema/graph/index.ts

@@ -13,6 +13,8 @@ import { ServiceModule } from '../../module/ServiceModule';
 import { GRAPH_OUTPUT_SERVICE, ServiceMetadata } from '../../Service';
 import { Storage } from '../../storage';
 
+/* eslint-disable @typescript-eslint/naming-convention */
+
 const GRAPH_INPUT_COMMAND_LIST = new GraphQLList(GRAPH_INPUT_COMMAND);
 const GRAPH_INPUT_MESSAGE_LIST = new GraphQLList(GRAPH_INPUT_MESSAGE);
 const GRAPH_OUTPUT_COMMAND_LIST = new GraphQLList(GRAPH_OUTPUT_COMMAND);

src/schema/index.ts

@@ -4,6 +4,8 @@ import Ajv from 'ajv';
 import { SCHEMA_KEYWORD_REGEXP } from './keyword/Regexp';
 import * as SCHEMA_GLOBAL from './schema.yml';
 
+export type SchemaDef = Record<string, unknown>;
+
 export interface SchemaResult {
   errors: Array<string>;
   valid: boolean;
@@ -22,9 +24,9 @@ export class Schema {
 
   protected compiler: Ajv.Ajv;
 
-  private readonly children: Map<string, object>;
+  private readonly children: Map<string, SchemaDef>;
 
-  constructor(schema: object = SCHEMA_GLOBAL) {
+  constructor(schema: SchemaDef = SCHEMA_GLOBAL) {
     this.children = new Map();
     this.compiler = new Ajv({
       allErrors: true,
@@ -40,7 +42,7 @@ export class Schema {
     this.addSchema('isolex', schema);
   }
 
-  public addSchema(name: string, schema: object) {
+  public addSchema(name: string, schema: SchemaDef) {
     if (!this.children.has(name)) {
       this.children.set(name, schema);
       this.compiler.addSchema(schema, name);

src/storage/index.ts

@@ -9,6 +9,8 @@ import { INJECT_ENTITIES } from '../module/EntityModule';
 import { INJECT_MIGRATIONS } from '../module/MigrationModule';
 import { ServiceLifecycle } from '../Service';
 
+/* eslint-disable @typescript-eslint/ban-types */
+
 export const INJECT_STORAGE_LOGGER = Symbol('inject-storage-logger');
 
 export interface StorageData extends BaseServiceData {

src/transform/index.ts

@@ -8,6 +8,7 @@ import { Service, ServiceDefinition } from '../Service';
 import { TemplateScope } from '../utils/Template';
 
 // @TODO: fix these good
+/* eslint-disable-next-line @typescript-eslint/ban-types */
 export type TransformInput = object;
 export type TransformOutput = TemplateScope;
 

src/utils/Metrics.ts

@@ -27,7 +27,7 @@ export function createServiceCounter(registry: Registry, config: Partial<Counter
   });
 }
 
-export function incrementServiceCounter(svc: Service, counter: StringCounter, data: object) {
+export function incrementServiceCounter(svc: Service, counter: StringCounter, data: Record<string, string | undefined>) {
   counter.inc({
     ...data,
     serviceId: svc.id,

src/utils/TemplateCompiler.ts

@@ -54,6 +54,7 @@ export class TemplateCompiler {
     return parts.join('');
   }
 
+  /* eslint-disable-next-line @typescript-eslint/ban-types */
   public formatJSON(value: object): hbs.SafeString {
     return new Handlebars.SafeString(JSON.stringify(value));
   }

src/utils/gitlab/index.ts

@@ -5,7 +5,8 @@ import { INJECT_LOGGER, INJECT_REQUEST } from '../../BaseService';
 import { classLogger } from '../../logger';
 import { RequestFactory, RequestOptions } from '../Request';
 
-/* eslint-disable camelcase */
+/* eslint-disable camelcase, @typescript-eslint/naming-convention */
+
 export interface GroupOptions {
   group: string;
 }

test/controller/TestEchoController.ts

@@ -85,7 +85,7 @@ describe('echo controller', async () => {
     const msg = 'hello world';
     module.bind('test-transform').toInstance(ineeda<Transform>({
       check: () => Promise.resolve(true),
-      transform: (c: Command, type: string, data: object) => Promise.resolve({
+      transform: (c: Command, type: string, data: Record<string, unknown>) => Promise.resolve({
         body: [msg],
       }),
     }));

test/controller/github/TestCommitController.ts

@@ -13,7 +13,8 @@ import { Transform } from '../../../src/transform';
 import { GithubClient } from '../../../src/utils/github';
 import { createService, createServiceContainer } from '../../helpers/container';
 
-/* eslint-disable @typescript-eslint/no-explicit-any, camelcase */
+/* eslint-disable @typescript-eslint/naming-convention,@typescript-eslint/no-explicit-any, camelcase */
+
 const TEST_TRANSFORM = 'test-transform';
 
 interface ClientResponse<T> {

test/endpoint/TestGitlabEndpoint.ts

@@ -9,6 +9,8 @@ import { GitlabEndpoint, GitlabEndpointData } from '../../src/endpoint/GitlabEnd
 import { CommandVerb } from '../../src/entity/Command';
 import { createEndpoint } from '../helpers/request';
 
+/* eslint-disable @typescript-eslint/naming-convention */
+
 const TEST_DATA: GitlabEndpointData = {
   defaultCommand: {
     data: {},

test/entity/base/TestBaseCommand.ts

@@ -4,7 +4,7 @@ import { BaseCommand } from '../../../src/entity/base/BaseCommand';
 import { CommandVerb } from '../../../src/entity/Command';
 
 class TestCommand extends BaseCommand {
-  public toJSON(): object {
+  public toJSON() {
     return {};
   }
 }

test/entity/base/TestDataEntity.ts

@@ -13,7 +13,7 @@ class TestEntity extends DataEntity<string> {
     this.labelStr = str;
   }
 
-  public toJSON(): object {
+  public toJSON() {
     return {};
   }
 }