Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix markdown parsing for italic #254

Merged
merged 2 commits into from
May 30, 2022
Merged

Fix markdown parsing for italic #254

merged 2 commits into from
May 30, 2022

Conversation

msglifeIberia
Copy link
Contributor

Fixes #251:

  1. Changed regex to support issue described in Markdown Italic does not work with word selected in middle #251
  2. Add tests for italic and bold markdown characters

@MSGInsurIt MSGInsurIt mentioned this pull request May 30, 2022
Closed
sstur
sstur approved these changes May 30, 2022
View reviewed changes
Copy link
Owner

@sstur sstur left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me, thanks for adding such comprehensive tests!

@sstur sstur changed the title Fix for #251 Fix markdown parsing for italic May 30, 2022
@sstur sstur merged commit be8c9d3 into sstur:master May 30, 2022
@MSGInsurIt
Copy link
Contributor

@sstur, Is a new release going to be created for this fix?

@sstur
Copy link
Owner

sstur commented Jun 8, 2022

Done. draft-js-utils@1.4.1 is published.

@just-another-jxliu just-another-jxliu mentioned this pull request Jun 11, 2022
Open
@sstur sstur mentioned this pull request Nov 1, 2022
Open
Nic0S added a commit to WonderInventions/draft-js-utils that referenced this pull request Nov 22, 2022
@Nic0S
Revert "Fix markdown parsing for italic (sstur#254)"
62a8f8d 
This reverts commit be8c9d3.

This commit causes issues on safari
@MSGInsurIt
Copy link
Contributor

@sstur will you be merging this code again... The safari release has been created with the support for negative lookbehind expressions:

Negative lookbehind assertion It's working now in Release 161 of Safari Technology Preview, downloads are here: [https://developer.apple.com/safari/resources/]
Safari Technology preview 161
Although it didn't make the cut for the release notes!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sstur sstur sstur approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Markdown Italic does not work with word selected in middle
3 participants
@msglifeIberia @MSGInsurIt @sstur