Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add null to defaultBlockTag ts type #215

Merged
merged 2 commits into from
Jul 26, 2020
Merged

add null to defaultBlockTag ts type #215

merged 2 commits into from
Jul 26, 2020

Conversation

voidpumpkin
Copy link
Contributor

draft-js-utils/packages/draft-js-export-html/src/stateToHTML.js

Lines 152 to 154 in 4007f3e

if (defaultBlockTag === null) {
return [];
}

^ That code was not reflected in typescript

@voidpumpkin
Copy link
Contributor Author

#201 #197

@voidpumpkin
Copy link
Contributor Author

@sstur

sstur
sstur approved these changes Jul 26, 2020
View reviewed changes
Copy link
Owner

@sstur sstur left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@sstur sstur merged commit 7318dce into sstur:master Jul 26, 2020
@hellatan
Copy link

@sstur do you know when you can publish this update?

@barklund barklund mentioned this pull request Sep 9, 2022
Merged
10 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sstur sstur sstur approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@voidpumpkin @hellatan @sstur