Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(markdown): trimming styled text #209

Merged
merged 4 commits into from
Aug 26, 2020
Merged

fix(markdown): trimming styled text #209

merged 4 commits into from
Aug 26, 2020

Conversation

ashbrowning
Copy link
Contributor

@ashbrowning ashbrowning commented Jan 9, 2020 •
edited by sstur
Loading

Resolves #208

If a word including its surrounding whitespace is formatted, the markdown output (while valid) will not correctly render the formatting.

@ashbrowning
fix(markdown): trimming styled text
1519966 
If a word including its surrounding whitespace is formatted, the
markdown output (while valid) will not correctly render the formatting.
@ashbrowning
fix(markdown): using trimLeft/Right vs trimStart/End for node v8
1683b3c
@ashbrowning ashbrowning requested a review from sstur January 22, 2020 11:15
@viococo
Copy link

viococo commented Feb 3, 2020

Same issue here, I am interested by this PR. Looking forward to have it soon in a new release :)

@etiennecaldichouryatnapta
Copy link

Same here! Thanks for the fix!

@jjjjeeffff jjjjeeffff mentioned this pull request Aug 26, 2020
Closed
sstur
sstur approved these changes Aug 26, 2020
View reviewed changes
Copy link
Owner

@sstur sstur left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good. Thanks @ashbrowning!

@sstur
Copy link
Owner

sstur commented Aug 26, 2020

Since the output ** foo ** is technically valid, we should probably fix this on the render side, rather than on the markdown creation side.

But for now this seems like a good workaround, so I'll merge this.

@sstur sstur merged commit 35937c2 into sstur:master Aug 26, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tappleby tappleby tappleby left review comments

@sstur sstur sstur approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Trailing space in style block results in misrendered markdown
5 participants
@ashbrowning @viococo @etiennecaldichouryatnapta @sstur @tappleby