Use <figure>s for images inserted from markdown #164
Conversation
This means they will be inserted as `atomic` blocks. Closes sstur#147
There was a problem hiding this comment.
I don't know how much I love the idea of:
- Using a wrapping
<figure> - Doing it in the markdown parser (as opposed to the draft-js content generator)
I feel like there's a more optimal solution, but.. since this is a working solution to a problem that has been around for a while, I think we should go ahead and land this (behind an option flag) and possibly come up with a more optimal solution another day.
| blocks, | ||
| }).toEqual({ | ||
| entityMap: { | ||
| // This is necessary due to flow not supporting non-string literal property keys |
There was a problem hiding this comment.
Oh, I think the trick here that I used in the past is:
{ [0]: "foo" }because IIRC Flow is fine when the number literal is in a computed property.
There was a problem hiding this comment.
I just copied that from the old tests 😉
|
I will put this behind an option 👍 |
|
Hmm, it seems like the Thanks for the quick review!! |
| const alt = 'The Google Logo'; | ||
| let markdown = ``; | ||
| let contentState = stateFromMarkdown(markdown, { | ||
| parserOptions: {atomicImages: true}, |
There was a problem hiding this comment.
@mxstbr: I added this here. Unless you have an objection to this approach, I'll go ahead and land this when the CI passes and I'll cut a release.
This means they will be inserted as
atomicblocks byimport-element, making them work out of the box with thedraft-js-image-plugin🎉Closes #147