Fix duplicate links in markdown import #161
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
`draft-js-import-markdown` does not correctly handle the case where two links to the same src are in a line.
|
It seems like the issue is with Digging into how to fix that 😅 |
This updates the _href regex to the new version from the marked codebase to fix the bug with two links in a line: https://github.com/markedjs/marked/blob/c77a2244ab5d4a0e1dec0979a51b80df87ec6409/lib/marked.js#L574
|
@sstur the latest commit fixes the bug by updating to the newest version of the https://github.com/markedjs/marked/blob/c77a2244ab5d4a0e1dec0979a51b80df87ec6409/lib/marked.js#L574 It might be time to remove the fork (if you can figure out why it was there in the first place 😅) and update marked to the latest version? |
mxstbr
changed the title
|
Awesome fix!
Yes, agreed. It should be not a huge effort to do this. |
|
This has been released in draft-js-import-markdown@1.3.0. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
draft-js-import-markdowndoes not correctly handle the case where two links to the same src are in a line. Any ideas why @sstur?Reference issue: https://github.com/withspectrum/spectrum/issues/4592