Fix code escaping #160
Merged
Fix code escaping #160
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sstur
force-pushed
the
fixCodeEscaping
branch
from
4a46420 to
b4c0795
Compare
sstur
force-pushed
the
fixCodeEscaping
branch
from
b4c0795 to
4683faa
Compare
mxstbr
approved these changes
Jan 28, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We should not escape underscores in inline code, and we should not escape any characters in code blocks.
Actually I'm not sure what characters we should escape in different contexts, but if anyone knows a reference for this, even for github flavored markdown, I'd be keen to know.