This repository has been archived by the owner on Jun 10, 2018. It is now read-only.
Fix: regex error with leading_digits #50
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When parsing `leading_digits` for number formats, `^` is being concatenated to the format, but many leading_digit formats contain the `|` operator. For this reason, `Format#match` returns some false positives. I.E., /^2|5[56]/ matches the phone number 1582380560. This commit wraps the leading_digits expression in ()s before applying the ^ so all of the formats must match the start of the line.
When we generate the national format for a given phone number, the output format is specified by the global_phone.json database. For example, New Zealand is '$1-$2 $3' where $1 is the national prefix, $2 is the first group of digits, and $3 is the last group of digits. However, when the national prefix is added to the number, we are erroneously inserting an extra space between the NP and the first group. For NZ, this results in '09 -123 1234', and for other countries it results in a double space: '02 1234 1234'. Since the spacing is included in the format specified by the DB, we should not need to add any additional spacing here.
Fix: do not insert an extra space in formatted numbers
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When parsing
leading_digitsfor number formats,^is beingconcatenated to the format, but many leading_digit formats contain the
|operator. For this reason,Format#matchreturns some falsepositives. I.E.,
/^2|5[56]/matches the phone number 1582380560.This commit wraps the leading_digits expression in ()s before applying
the ^ so all of the formats must match the start of the line.