Fix clipboard on Wayland systems #941
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
On Linux systems running a Wayland session, clipboard functionality could fail if both `wl-clipboard` and an X11-based tool like `xsel` were installed. The existing implementation did not prioritize the Wayland-native tool. This change addresses the issue by: - Detecting a Wayland environment via the `WAYLAND_DISPLAY` variable. - Adjusting the tool preference order to prioritize `wl-copy`. - Correcting the tool name from `wl-clipboard` to `wl-copy` to ensure it is found in the system's PATH.
|
As a filthy macos user I have no way to test this atm, can you confirm this doesn't break paste? |
|
Regarding MacOS, that's okay, nobody is perfect. ;-) I updated the docs to clarify that wl-clipboard is preferred for systems running Wayland. You're right that Previously we were looking for a daniel@redhotcar:~$ which wl-clipboard
daniel@redhotcar:~$ which wl-copy
/usr/bin/wl-copy |
|
thanks a ton for this, please let me know if you see any other wayland issues in opencode! |
ndraiman
pushed a commit
to ndraiman/opencode
that referenced
this pull request
Jul 15, 2025
Co-authored-by: Daniel Nouri <daniel@redhotcar>
achembarpu
pushed a commit
to achembarpu/opencode
that referenced
this pull request
Aug 4, 2025
Co-authored-by: Daniel Nouri <daniel@redhotcar>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
On Linux systems running a Wayland session, clipboard functionality could fail if both
wl-clipboardand an X11-based tool likexselwere installed. The existing implementation did not prioritize the Wayland-native tool.This change addresses the issue by:
WAYLAND_DISPLAYvariable.wl-copy.wl-clipboardtowl-copyto ensure it is found in the system's PATH.