fix: wait for stdout to flush in generate command #3821
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Prevents truncation of OpenAPI spec output at 64KB when piping to jq/yq. The process.exit() call in the finally block was terminating before stdout could finish flushing asynchronous writes to the pipe. Before this fix: bun run src/index.ts generate | jq # jq: parse error: Unfinished JSON term at EOF at line 2605, column 2 After this fix: bun run src/index.ts generate | jq # Successfully parses full 181KB spec
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Fixes truncation of OpenAPI spec output at 64KB when piping to
jqoryq.Problem
The
generatecommand was writing JSON output to stdout without waiting for the write to complete. When the process exits viaprocess.exit()in the finally block, stdout buffers are not fully flushed when writing to a pipe, causing output to be truncated at exactly 65,536 bytes (64KB).Before this fix:
After this fix:
Solution
Wait for the
process.stdout.write()callback to complete before allowing the process to exit. This ensures all buffered data is flushed to the pipe.Testing
Verified that piping to both
jqandyqnow works correctly:bun run src/index.ts generate | jq .- ✅ parses successfullybun run src/index.ts generate | yq -p json -o yaml- ✅ converts successfully