fix(keybind): changed conflicting keybind for renderer.console.toggle() #3718
+1
−1
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
spikedoanz
changed the title
spikedoanz
changed the title
spikedoanz
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
problem + solution
addresses #3652 by changing the binding for renderer.console.toggle() from meta+d (which conflicts with ctrl+meta+d for scroll down) to meta+f12.
f12 was chosen since it's the default for lots of tooling like browsers, but realistically anything that doesn't overlap with an existing binding should be good.
tests
this pr doesn't touch any runtime code. both bun dev and all 149 bun tests pass.