fix: Fix worker.ts path for production and dev #3660
Conversation
|
this needs to be tested by running |
| "test": "bun test", | ||
| "build": "./script/build.ts", | ||
| "dev": "bun run --conditions=browser ./src/index.ts", | ||
| "dev": "NODE_ENV=development bun run --conditions=browser ./src/index.ts", |
There was a problem hiding this comment.
I doubt that without exporting the variable, it will work reliabily.
|
Thanks for checking, I saw this one yesterday and it should fix the issue #3778 |
|
There are a few PRs trying to address this. The problem with my fix here is that when you build using build.ts, the built executable sees NODE_ENV=development for some reason. I converted it to a draft because I wanted to find out how to make it NODE_ENV=production in the production version. I'm currently busy with the tests, so someone else can tackle this if they want to. |
It's a way better fix. But you should really mention that you are trying to work around a bun bug: oven-sh/bun#15981 and that, at some point, it will be not needed anymore and rely on a bun version check. |
4 participants
No description provided.