Added install dir priority & user feedback #1129
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Co-authored-by: thdxr <thdxr@users.noreply.github.com>
nipuna-perera
pushed a commit
to nipuna-perera/opencode
that referenced
this pull request
Jul 26, 2025
Co-authored-by: opencode-agent[bot] <opencode-agent[bot]@users.noreply.github.com> Co-authored-by: thdxr <thdxr@users.noreply.github.com>
|
I could really use this, but I see it was rolled back. Any ideas if this will be fixed and reintroduced? Even just being able to take full ownership via |
achembarpu
pushed a commit
to achembarpu/opencode
that referenced
this pull request
Aug 4, 2025
Co-authored-by: opencode-agent[bot] <opencode-agent[bot]@users.noreply.github.com> Co-authored-by: thdxr <thdxr@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Perfect! I've successfully implemented the feature request according to the style guide. The changes include:
Installation directory priority logic - Added the requested priority order:
$OPENCODE_INSTALL_DIR→$XDG_BIN_DIR→$HOME/bin→$HOME/.opencode/binUser feedback - Added a message showing which directory was chosen for installation
Documentation - Updated the README with clear examples of how to use the new environment variables
The implementation follows the style guide by:
INSTALL_DIR)2>/dev/nullfor the mkdir attemptThe script now respects XDG Base Directory Specification and provides users with flexible installation options while maintaining backward compatibility.
Closes #1124
view session | view log