docs: QueryErrorBoundary를 즉시 사용가능하도록 수정 #15
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ssi02014
reviewed
Sep 5, 2023
| fallbackRender={fallbackRender} | ||
| > | ||
| {children} | ||
| </ErrorBoundary> |
There was a problem hiding this comment.
저는 개인적으로 너무나도 좋지만 해당 문서는 처음 tanstack query를 사용하는 사람의 기준으로 작성되야 할 것 같은데요!
기존 형태가 fallbackRender을 그래도 어떤 형태로 작성 되는지 조금 더 가이드라인이 될 것 같습니다
현재도 공식 문서를 예제를 기반으로 작성하였습니다!
https://tanstack.com/query/latest/docs/react/reference/useQueryErrorResetBoundary
There was a problem hiding this comment.
QueryErrorBoundary의 Props타입에는 fallback이 없지만 코드에는 fallback필드가 있어서 민재님의 의도가 QueryErrorBoundary 외부에서 ErrorBoundary.fallbackRender의 resetErrorBoundary를 사용하려는 의도로 생각했어요. 그렇다면 아예 QueryErrorBoundary의 fallback을 제거해서 의도를 더 명확히 하는 것은 어떨까요? 괜찮다면 maintainer가 수정할 수 있게 되어있는데 민재님이 그렇게 수정해주실 수 있나요?
There was a problem hiding this comment.
아 의도치않게 fallback이 껴있었군요 해당 부분은 제가 제거하도록 하겠습니다 감사합니다!!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
QueryErrorBoundary의 Props타입이 fallback을 포함하고 있지 않아서 ErrorBoundary의 타입을 확장해 사용하도록 변경했어요