Skip to content

Add support for host resolution by the proxy itself #77

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 4 commits into from

Conversation

pirrmann
Copy link

I have a business case where the proxy I need to use has a set of permissions based on the targetted host name, and rejects connections targetting an IP address.
SOCKS5 allows sending the host name instead of the locally-resolved IP addess, so I've implemented support for that.

@pirrmann
Copy link
Author

Hello,
I'm aware that this is an open-source project and that everyone involved is doing it on his/her spare time. However, could someone have a look at my pull request? I'm ready to improve it if it does not comply to the project's standards, but I'd like to know if merging it will be possible of if I have to find another way of solving my issue.
Thanks, Pierre.

@pirrmann
Copy link
Author

Thanks for all the kind answers on this pull request, is it worth my time to try to fix the conflicts in this branch?

@drieseng
Copy link
Member

drieseng commented Sep 23, 2018

I'm not sure if we should go for this approach, or use an EndPoint argument (which could be IPEndPoint or DnsEndPoint). Any thoughts?

@glenncarr
Copy link

Any more thoughts about this?

@pirrmann
Copy link
Author

Closing this one after 6 years. If someone thinks that this is still relevant, please consider #919 or open another PR.

@pirrmann pirrmann closed this Nov 16, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants