Skip to content

Expose SshIdentificationReceived event #1195

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 12 commits into from
Nov 16, 2023
Merged

Expose SshIdentificationReceived event #1195

merged 12 commits into from
Nov 16, 2023

Conversation

scott-xu
Copy link
Collaborator

No description provided.

@scott-xu scott-xu marked this pull request as draft September 29, 2023 09:01
@scott-xu scott-xu marked this pull request as ready for review November 15, 2023 13:38
@scott-xu scott-xu changed the title Fix https://github.com/sshnet/SSH.NET/issues/1191 Expose SshIdentificationReceived event Nov 15, 2023
@WojciechNagorski
Copy link
Collaborator

@scott-xu Can you describe why you need this? What is your use case?

@scott-xu
Copy link
Collaborator Author

It is described in #1191

@WojciechNagorski
Copy link
Collaborator

@scott-xu How this PR is related with #972 - you mention it here #1191 (comment)

Sorry for the questions but sometimes it is hard to understand the relationship between issues and PR.

@scott-xu
Copy link
Collaborator Author

@WojciechNagorski With this PR, plus #972, lib user can set InitiateKeyExchange to true/false based on server type Cisco/non-Cisco

@WojciechNagorski
Copy link
Collaborator

@scott-xu I know this, but there are no tests so I would like to know how users will use it. I don't have enough time to figure out how to use it, especially if it is divided into 2 PRs.

If you want me to review and merge this I need unit or integration tests or a description of how to use it.

@scott-xu
Copy link
Collaborator Author

scott-xu commented Nov 16, 2023 •
edited
Loading

@WojciechNagorski Tests are added. I also renamed the event to ServerIdentificationReceived.
https://github.com/sshnet/SSH.NET/pull/1195/files#diff-a5e8d1be9212cb37167bf627f1723c331ddaa2cefddd9fa349acd562d8d3325fR16

WojciechNagorski
WojciechNagorski approved these changes Nov 16, 2023
View reviewed changes
Copy link
Collaborator

@WojciechNagorski WojciechNagorski left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! I tested it.

@WojciechNagorski WojciechNagorski merged commit f9f2b0e into sshnet:develop Nov 16, 2023
@WojciechNagorski WojciechNagorski added this to the 2023.0.1 milestone Nov 16, 2023
@WojciechNagorski WojciechNagorski mentioned this pull request Dec 29, 2023
Closed
@WojciechNagorski
Copy link
Collaborator

The 2023.0.1 version has been released to Nuget: https://www.nuget.org/packages/SSH.NET/2023.0.1

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@WojciechNagorski WojciechNagorski WojciechNagorski approved these changes

@drieseng drieseng Awaiting requested review from drieseng drieseng is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
2023.0.1
Development

Successfully merging this pull request may close these issues.
2 participants
@scott-xu @WojciechNagorski