Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ShellStream.ReadLine only recognises CrLf as a line ending #748

Closed
martingbrown opened this issue Dec 7, 2020 · 2 comments · Fixed by #1322
Closed

ShellStream.ReadLine only recognises CrLf as a line ending #748

martingbrown opened this issue Dec 7, 2020 · 2 comments · Fixed by #1322
Labels
enhancement
Milestone
2024.0.0

Comments

@martingbrown
Copy link

I am connecting to a server that ends its lines with a single Cr. Because ShellStream.ReadLine is looking for CrLf it is not finding the end of the line.

I propose that this method be changed to look for CrLf or Cr or Lf that should cover most cases.
@IgorMilavec
Copy link
Collaborator

I have created a discussion #926 for all ShellStream related issues.

@Rob-Hague Rob-Hague mentioned this issue Feb 13, 2024
Merged
@WojciechNagorski
Copy link
Collaborator

This issue has been fixed in the 2024.0.0 version.

@WojciechNagorski WojciechNagorski added this to the 2024.0.0 milestone Feb 22, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement
Projects
None yet
Milestone
2024.0.0
Development

Successfully merging a pull request may close this issue.

Fix a few issues with ShellStream Rob-Hague/SSH.NET
3 participants
@martingbrown @IgorMilavec @WojciechNagorski