Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature to alert user of faster adjacent lanes #116

Merged
merged 109 commits into from
Jul 1, 2020

Conversation

sshane
Copy link
Owner

@sshane sshane commented Jun 19, 2020

idea thanks to greengree

Features:

  • alerts you if you are using openpilot and an adjacent lane is traveling on average faster than your current lane
    • does not alert you if:
      • you are below a minimum highway speed
      • you are not engaged
  • works well in curves, it offsets the lane positions using dPoly and every track's distance

Dynamic follow changes:

  • If effective profile is changed, increase cost temporarily to get to new profile distance quicker

todo:

  • make roadtrip and relaxed farther
  • tune how often it alerts the user, and for how long
  • move lanespeed to a new process
  • add button to screen to enable/disable alert
  • add better decision making deciding when to alert user
    • right now it just waits for a specific amount of time of a lane being faster before alerting
      • maybe disable alerts if user recently changed lanes
      • maybe change minimum fastest lane time based on speed or traffic conditions
        • working on this, just need to tune it
  • change the lane width dynamically based on what openpilot sees from the model
  • Fix how adjacent lane lines are interpreted. Right now we just add the lane width to the path, however we should angle it based on the path's position from car so that the lane width remains constant, no matter what angle the path is at

@sshane sshane marked this pull request as draft June 19, 2020 06:40
@sshane sshane marked this pull request as ready for review June 19, 2020 06:40
@sshane sshane marked this pull request as draft June 19, 2020 06:40
@sshane sshane force-pushed the stock_additions-lane-speed branch from 14fc0fc to 295c437 Compare June 27, 2020 00:35
@sshane sshane marked this pull request as ready for review June 30, 2020 05:58
@sshane sshane merged commit ea1ea1c into stock_additions Jul 1, 2020
@sshane sshane deleted the stock_additions-lane-speed branch July 18, 2020 23:07
Aragon7777 pushed a commit to Aragon7777/openpilot that referenced this pull request Aug 9, 2021
* start cleanup

* controlsState is horrible

* more controlsState cleanup

* carstate

* cleanup plan packets

* rename events

* update mono times

* update service list

* don't need multiple radar alerts

* small car.capnp cleanup

* start thermal cleanup

* fan speed

* model packets

* fix build

* hw -> panda

* capitalize

* deprecate rest of warp matrices

* generate headers
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant