feat: prometheus metrics #508
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
masaruhoshi
force-pushed
the
prometheus-support
branch
from
6e3a1be
to
e504dcf
Compare
tluimes
force-pushed
the
prometheus-support
branch
from
8d60228
to
ec33a33
Compare
|
Addresses feature issue: #511 |
xopham
reviewed
Feb 4, 2022
There was a problem hiding this comment.
@masaruhoshi @tluimes great work! Really like the feature 🚀
I have some comments on e.g. the service port (which I think is valid, but not well scoped to the PR), the docs update (will provide basic infrastructure)...
Thanks for the contribution 🙏
xopham
reviewed
Feb 4, 2022
xopham
reviewed
Feb 4, 2022
There was a problem hiding this comment.
generally, looks good to me know. I have one remaining comment. Once that is resolved, the pytests are fixed and it is squashed into one commit, I'd be happy to merge it.
There is some help on how to run pytest locally: https://sse-secure-systems.github.io/connaisseur/develop/CONTRIBUTING/#test-changes
Let me know if you need any help 🙂
masaruhoshi
force-pushed
the
prometheus-support
branch
from
aef0ac4
to
fa39d81
Compare
xopham
previously approved these changes
Feb 8, 2022
xopham
force-pushed
the
prometheus-support
branch
from
64848b8
to
e5f81a8
Compare
Co-authored-by: Masaru Hoshi <masaru.hoshi@qlik.com> Co-authored-by: Tim Luimes <tluimes@gmail.com>
xopham
force-pushed
the
prometheus-support
branch
from
e5f81a8
to
77ab33b
Compare
xopham
approved these changes
Feb 8, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Introduces simple metrics for Flask application using prometheus-flask-exporter for mutate endpoints. The metrics are available from the /metrics endpoint.
It also introduces the possibility to specify a different port for the mutating webhook based on the service port.
Checklist
developvalues.yamlandChart.yaml(if necessary)