feat: update AGENTS and README metadata, enhance chat API #5
There are no files selected for viewing
| Original file line number | Diff line number | Diff line change | ||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|
| @@ -1,64 +1,21 @@ | ||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
| import { mastra } from "../../../src/mastra"; | ||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
| import { RuntimeContext } from "@mastra/core/runtime-context"; | ||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
|
Comment on lines
+1
to
+2
There was a problem hiding this comment. 🧹 Nitpick | 🔵 Trivial Import path uses relative path instead of alias. The import uses -import { mastra } from "../../../src/mastra";
+import { mastra } from "@/src/mastra";📝 Committable suggestion
Suggested change
🤖 Prompt for AI Agents |
||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
|
|
||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
|
Comment on lines
+1
to
3
Contributor
There was a problem hiding this comment. The import { mastra } from "../../../src/mastra";
import { RuntimeContext } from "@mastra/core/runtime-context";
export const maxDuration = 60;There was a problem hiding this comment. The removed
Suggested change
|
||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
| export async function POST(req: Request) { | ||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
| const { messages, data } = await req.json(); | ||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
|
There was a problem hiding this comment. logic: No validation for required Prompt To Fix With AIThis is a comment left during a code review.
Path: app/api/chat/route.ts
Line: 5:5
Comment:
**logic:** No validation for required `messages` field - will throw if undefined/missing from request body
How can I resolve this? If you propose a fix, please make it concise.There was a problem hiding this comment. Missing input validation for required fields. The code assumes
Suggested change
|
||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
| const myAgent = mastra.getAgent("weatherAgent"); | ||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
|
Comment on lines
4
to
+6
There was a problem hiding this comment. Missing input validation for request body. As per coding guidelines, API routes should validate user input server-side using a validation library like +import { z } from "zod";
+
+const ChatRequestSchema = z.object({
+ messages: z.array(z.object({
+ role: z.string(),
+ content: z.string(),
+ })),
+ data: z.record(z.unknown()).optional(),
+});
+
export async function POST(req: Request) {
- const { messages, data } = await req.json();
+ const body = await req.json();
+ const { messages, data } = ChatRequestSchema.parse(body);
const myAgent = mastra.getAgent("weatherAgent");📝 Committable suggestion
Suggested change
🤖 Prompt for AI AgentsThere was a problem hiding this comment. 🧹 Nitpick | 🔵 Trivial Hardcoded agent name reduces flexibility. The agent is hardcoded to 🤖 Prompt for AI AgentsThere was a problem hiding this comment. logic: Agent ID mismatch -
Suggested change
Prompt To Fix With AIThis is a comment left during a code review.
Path: app/api/chat/route.ts
Line: 6:6
Comment:
**logic:** Agent ID mismatch - `weatherAgent` doesn't exist. The agent is registered with ID `weather-agent` (see `src/mastra/agents/weather-agent.ts:18`). This will cause runtime errors.
```suggestion
const myAgent = mastra.getAgent("weather-agent");
```
How can I resolve this? If you propose a fix, please make it concise.
Comment on lines
+5
to
+6
There was a problem hiding this comment. The chat API is hardcoded to use only "weatherAgent", removing the ability to select different agents dynamically. The previous implementation supported dynamic agent selection via
Suggested change
|
||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
|
|
||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
| const runtimeContext = new RuntimeContext(); | ||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
|
|
||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
| if (data) { | ||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
| for (const [key, value] of Object.entries(data)) { | ||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
| runtimeContext.set(key, value); | ||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
| } | ||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
| } | ||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
|
|
||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
| const stream = await myAgent.stream(messages, { | ||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
| runtimeContext, | ||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
| format: "aisdk", | ||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
| }); | ||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
| return stream.toUIMessageStreamResponse(); | ||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
|
Comment on lines
4
to
+20
There was a problem hiding this comment. logic: No try-catch error handling - unhandled exceptions will crash the API route instead of returning proper error responses Prompt To Fix With AIThis is a comment left during a code review.
Path: app/api/chat/route.ts
Line: 4:20
Comment:
**logic:** No try-catch error handling - unhandled exceptions will crash the API route instead of returning proper error responses
How can I resolve this? If you propose a fix, please make it concise. |
||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
| } | ||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
|
Comment on lines
4
to
+21
Contributor
There was a problem hiding this comment. The chat API has been hardcoded to only use the export async function POST(req: Request) {
const { messages, data } = await req.json();
const agentId = data?.agentId ?? "weatherAgent";
const agent = mastra.getAgent(agentId);
if (!agent) {
const availableAgents = Object.keys(await mastra.getAgents());
return Response.json(
{ error: `Agent '${agentId}' not found. Available agents: ${availableAgents.join(', ')}` },
{ status: 400 }
);
}
const runtimeContext = new RuntimeContext();
if (data) {
const { agentId: _, ...contextData } = data;
for (const [key, value] of Object.entries(contextData)) {
runtimeContext.set(key, value);
}
}
const stream = await agent.stream(messages, {
runtimeContext,
format: "aisdk",
});
return stream.toUIMessageStreamResponse();
}
Comment on lines
4
to
+21
There was a problem hiding this comment. Missing error handling for async operations. Per coding guidelines, use export async function POST(req: Request) {
+ try {
const { messages, data } = await req.json();
const myAgent = mastra.getAgent("weatherAgent");
const runtimeContext = new RuntimeContext();
if (data) {
for (const [key, value] of Object.entries(data)) {
runtimeContext.set(key, value);
}
}
const stream = await myAgent.stream(messages, {
runtimeContext,
format: "aisdk",
});
return stream.toUIMessageStreamResponse();
+ } catch (error) {
+ console.error("Chat API error:", error);
+ return new Response(
+ JSON.stringify({ error: "Failed to process chat request" }),
+ { status: 500, headers: { "Content-Type": "application/json" } }
+ );
+ }
}🤖 Prompt for AI Agents
Comment on lines
+1
to
+21
There was a problem hiding this comment. logic: Removed all dynamic agent selection, error handling, validation, and the GET endpoint. The previous implementation supported any agent via Prompt To Fix With AIThis is a comment left during a code review.
Path: app/api/chat/route.ts
Line: 1:21
Comment:
**logic:** Removed all dynamic agent selection, error handling, validation, and the GET endpoint. The previous implementation supported any agent via `agentId` parameter and had proper error handling. Now it only works with one hardcoded agent. Is this intentional? This breaks existing functionality for multi-agent chat.
How can I resolve this? If you propose a fix, please make it concise.
Comment on lines
4
to
+21
There was a problem hiding this comment. The simplified API removed error handling that was present in the previous implementation. Consider wrapping the stream call in a try-catch block to handle potential errors gracefully and return appropriate error responses to the client. |
||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
| Original file line number | Diff line number | Diff line change | ||||
|---|---|---|---|---|---|---|
|
|
@@ -3,6 +3,8 @@ import { | |||||
| createUIMessageStreamResponse, | ||||||
| } from "ai"; | ||||||
| import { toAISdkFormat } from "@mastra/ai-sdk"; | ||||||
| import type { Mastra } from "@mastra/core/mastra"; | ||||||
| import type { AgentExecutionOptions } from "@mastra/core/agent"; | ||||||
| import type { MastraModelOutput } from "@mastra/core/stream"; | ||||||
|
|
||||||
| export interface StreamToAISdkOptions { | ||||||
|
|
@@ -16,34 +18,34 @@ export interface AgentStreamOptions { | |||||
| format?: "aisdk" | "mastra"; | ||||||
| threadId?: string; | ||||||
| resourceId?: string; | ||||||
| memory?: AgentExecutionOptions["memory"]; | ||||||
| maxSteps?: number; | ||||||
| } | ||||||
|
|
||||||
| type StreamResult = MastraModelOutput & { toUIMessageStreamResponse?: () => Response }; | ||||||
|
|
||||||
| function isReadableStream<T>(value: unknown): value is ReadableStream<T> { | ||||||
| return ( | ||||||
| typeof value === "object" && | ||||||
| value !== null && | ||||||
| typeof (value as ReadableStream<T>).getReader === "function" | ||||||
| ); | ||||||
| } | ||||||
|
|
||||||
| async function* asyncIterableFromReadableStream<T>( | ||||||
| stream: ReadableStream<T> | ||||||
| ): AsyncIterable<T> { | ||||||
| const reader = stream.getReader(); | ||||||
| try { | ||||||
| while (true) { | ||||||
| const { done, value } = await reader.read(); | ||||||
| if (done) break; | ||||||
| yield value; | ||||||
| } | ||||||
| } finally { | ||||||
| reader.releaseLock(); | ||||||
| } | ||||||
| } | ||||||
|
|
||||||
| /** | ||||||
| * Creates a streaming Response for Next.js API routes using server-side Mastra agent. | ||||||
|
|
@@ -55,7 +57,7 @@ type MastraInstance = { | |||||
| * ```ts | ||||||
| * // app/api/chat/route.ts | ||||||
| * import { mastra } from "@/src/mastra"; | ||||||
| * import { createAgentStreamResponse } from "@/lib/server/agent-stream"; | ||||||
|
There was a problem hiding this comment. The documentation references an incorrect import path
Suggested change
|
||||||
| * | ||||||
| * export async function POST(req: Request) { | ||||||
| * const { messages, agentId, threadId, resourceId, memory } = await req.json(); | ||||||
|
|
@@ -70,7 +72,7 @@ type MastraInstance = { | |||||
| * @see https://mastra.ai/docs/frameworks/agentic-uis/ai-sdk | ||||||
| */ | ||||||
| export async function createAgentStreamResponse( | ||||||
| mastra: Mastra, | ||||||
| agentId: string, | ||||||
| messages: unknown, | ||||||
| options?: AgentStreamOptions | ||||||
|
|
@@ -85,34 +87,27 @@ export async function createAgentStreamResponse( | |||||
| maxSteps: options?.maxSteps, | ||||||
| }; | ||||||
|
|
||||||
| // Call agent.stream once and reuse the result | ||||||
| const stream = await agent.stream(messages, streamOptions) as StreamResult; | ||||||
|
|
||||||
| // Preferred: Use built-in AI SDK format when available | ||||||
| if (streamOptions.format === "aisdk" && stream.toUIMessageStreamResponse) { | ||||||
|
There was a problem hiding this comment. The code calls
Suggested change
|
||||||
| return stream.toUIMessageStreamResponse(); | ||||||
| } | ||||||
|
|
||||||
| // Fallback: Manual transformation with toAISdkFormat | ||||||
| // Handles both ReadableStream and AsyncIterable return types | ||||||
| const uiMessageStream = createUIMessageStream({ | ||||||
| execute: async ({ writer }) => { | ||||||
| const aiSdkResult = toAISdkFormat(stream, { from: "agent" }); | ||||||
|
|
||||||
| // Handle both ReadableStream and AsyncIterable | ||||||
| const iterable: AsyncIterable<unknown> = isReadableStream(aiSdkResult) | ||||||
| ? asyncIterableFromReadableStream(aiSdkResult) | ||||||
| : aiSdkResult; | ||||||
|
|
||||||
| for await (const value of iterable) { | ||||||
| writer.write(value as Parameters<typeof writer.write>[0]); | ||||||
| } | ||||||
|
Comment on lines
+109
to
111
There was a problem hiding this comment. 🧹 Nitpick | 🔵 Trivial Type assertion is acceptable but consider stronger typing. The cast 🤖 Prompt for AI Agents |
||||||
| }, | ||||||
| }); | ||||||
|
|
||||||
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,5 +1,12 @@ | ||
| import { MastraClient } from "@mastra/client-js"; | ||
|
|
||
| /** | ||
| * Client-side Mastra SDK instance for frontend use. | ||
| * Use this in React components to interact with the Mastra API. | ||
| * | ||
| * For server-side streaming in API routes, import createAgentStreamResponse | ||
| * directly from "@/lib/client-stream-to-ai-sdk" instead. | ||
| */ | ||
|
Comment on lines
+3
to
+9
There was a problem hiding this comment. The comment directs users to import from |
||
| export const mastraClient = new MastraClient({ | ||
| baseUrl: process.env.NEXT_PUBLIC_MASTRA_API_URL || "http://localhost:4111", | ||
| retries: 3, | ||
|
|
@@ -9,6 +16,3 @@ export const mastraClient = new MastraClient({ | |
| headers: {}, | ||
| credentials: "same-origin", | ||
| }); | ||
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Minor grammar fix: use hyphen in compound modifier.
Per static analysis, "code-agent focused" should use a hyphen when used as a compound adjective.
📝 Committable suggestion
🧰 Tools
🪛 LanguageTool
[grammar] ~125-~125: Use a hyphen to join words.
Context: .../mastra/AGENTS.md`: top-level code-agent focused docs (this file is mirrored to s...
(QB_NEW_EN_HYPHEN)
🤖 Prompt for AI Agents