feat: Enhance tool progress reporting and add new agents/tools #48
There are no files selected for viewing
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -163,7 +163,7 @@ Carefully read the issue and think hard about a plan to solve it before coding. | |
|
|
||
| ## 8. Debugging | ||
|
|
||
| - Use the `'read/problems'` tool to identify and report any issues in the code. This tool replaces the previously used `get_errors` tool. | ||
| - Make code changes only if you have high confidence they can solve the problem | ||
| - When debugging, try to determine the root cause rather than addressing symptoms | ||
| - Debug for as long as needed to identify the root cause and identify a fix | ||
|
|
||
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -77,6 +77,7 @@ | |
| "@monaco-editor/react": "^4.8.0-rc.3", | ||
| "@next/bundle-analyzer": "^16.0.10", | ||
| "@next/mdx": "^16.0.10", | ||
| "@octokit/plugin-retry": "^8.0.3", | ||
| "@openrouter/ai-sdk-provider": "^1.5.3", | ||
| "@opentelemetry/api": "^1.9.0", | ||
| "@opentelemetry/exporter-trace-otlp-proto": "^0.208.0", | ||
|
|
@@ -215,4 +216,4 @@ | |
| "body-parser": "^2.2.1", | ||
| "jws": "^4.0.1" | ||
| } | ||
| } | ||
| Original file line number | Diff line number | Diff line change | ||||||||
|---|---|---|---|---|---|---|---|---|---|---|
| @@ -0,0 +1,18 @@ | ||||||||||
| import { Agent } from "@mastra/core/agent"; | ||||||||||
| import { Memory } from "@mastra/memory"; | ||||||||||
| import { colorChangeTool } from "../tools/color-change-tool"; | ||||||||||
|
There was a problem hiding this comment. Incorrect import path. The import path references Apply this diff to fix the import: -import { colorChangeTool } from "../tools/color-change-tool";
+import { colorChangeTool } from "../color-change-tool";Alternatively, move 📝 Committable suggestion
Suggested change
🤖 Prompt for AI AgentsThere was a problem hiding this comment. The import path '../tools/color-change-tool' is inconsistent. The file is actually located at '../color-change-tool' (not in a tools subdirectory based on the PR diff).
Suggested change
|
||||||||||
|
|
||||||||||
| export const bgColorAgent = new Agent({ | ||||||||||
| id: "bg-color-agent", | ||||||||||
| name: "Background Color Agent", | ||||||||||
| description: | ||||||||||
| "This agent takes in a color, converts it to HEX format and changes the background color of the application.", | ||||||||||
| instructions: ` | ||||||||||
| You are a helpful assistant to change the background color of the application. | ||||||||||
| You will be given a color in any format (e.g., "red", "rgb(255, 0, 0)", "hsl(0, 100%, 50%)"). | ||||||||||
| Your task is to convert this color to HEX format (e.g., "#FF0000") and call the colorChangeTool with the HEX color. | ||||||||||
| `, | ||||||||||
| model: "openai/gpt-4o-mini", | ||||||||||
| tools: { colorChangeTool }, | ||||||||||
|
Contributor
There was a problem hiding this comment. The |
||||||||||
| memory: new Memory(), | ||||||||||
| }); | ||||||||||
|
Comment on lines
+5
to
+18
There was a problem hiding this comment. 🧩 Analysis chain🏁 Script executed: # Check the actual filename and list all agent files with their naming conventions
fd -e ts . src/mastra/agents/ -type f | sortRepository: ssdeanx/AgentStack Length of output: 232 🏁 Script executed: # List all TypeScript files in src/mastra/agents directory
fd -e ts src/mastra/agents/Repository: ssdeanx/AgentStack Length of output: 439 🏁 Script executed: # List all TypeScript files in src/mastra/agents directory
fd . 'src/mastra/agents/' -e tsRepository: ssdeanx/AgentStack Length of output: 1160 Rename file to follow kebab-case naming convention. The file 🤖 Prompt for AI Agents |
||||||||||
| Original file line number | Diff line number | Diff line change | ||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|
| @@ -0,0 +1,16 @@ | ||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
| import { createTool } from "@mastra/client-js"; | ||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
| import z from "zod"; | ||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
|
|
||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
| export function changeBgColor(color: string) { | ||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
| if (typeof window !== "undefined") { | ||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
| document.body.style.setProperty("--background", color); | ||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
| } | ||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
| } | ||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
|
Comment on lines
+4
to
+8
There was a problem hiding this comment. CSS variable may not propagate correctly. Setting Consider using export function changeBgColor(color: string) {
if (typeof window !== "undefined") {
- document.body.style.setProperty("--background", color);
+ document.documentElement.style.setProperty("--background", color);
}
}📝 Committable suggestion
Suggested change
🤖 Prompt for AI Agents |
||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
|
|
||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
| export const colorChangeTool = createTool({ | ||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
| id: "changeColor", | ||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
| description: "Changes the background color", | ||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
| inputSchema: z.object({ | ||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
| color: z.string(), | ||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
| }), | ||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
|
There was a problem hiding this comment. The tool is missing an
Suggested change
|
||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
| }); | ||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
|
Comment on lines
+10
to
+16
Contributor
There was a problem hiding this comment. The The export const colorChangeTool = createTool({
id: "changeColor",
description: "Changes the background color",
inputSchema: z.object({
color: z.string(),
}),
outputSchema: z.object({
success: z.boolean(),
}),
execute: async ({ color }, { writer }) => {
// On the server, we can't change the DOM directly.
// Instead, we send a custom event to the client to handle the color change.
await writer?.custom({
type: 'ui-update',
data: {
component: 'background',
properties: {
color: color,
},
},
});
return { success: true };
},
});
Comment on lines
+10
to
+16
There was a problem hiding this comment. syntax: tool missing
Suggested change
Prompt To Fix With AIThis is a comment left during a code review.
Path: src/mastra/color-change-tool.ts
Line: 10:16
Comment:
**syntax:** tool missing `execute` function - will cause runtime error
```suggestion
export const colorChangeTool = createTool({
id: "changeColor",
description: "Changes the background color",
inputSchema: z.object({
color: z.string(),
}),
execute: async ({ context }) => {
changeBgColor(context.color);
return { success: true, color: context.color };
},
});
```
How can I resolve this? If you propose a fix, please make it concise.
Comment on lines
+1
to
+16
There was a problem hiding this comment. 🧹 Nitpick | 🔵 Trivial Add TSDoc documentation for exported entities. Per coding guidelines, public APIs should have TSDoc comments including parameter descriptions and purpose. +/**
+ * Updates the application's background color by setting a CSS custom property.
+ * @param color - The color value to apply (any valid CSS color format)
+ */
export function changeBgColor(color: string) {
if (typeof window !== "undefined") {
document.body.style.setProperty("--background", color);
}
}
+/**
+ * Tool for changing the application's background color.
+ * Accepts a color string and applies it to the --background CSS variable.
+ */
export const colorChangeTool = createTool({📝 Committable suggestion
Suggested change
🤖 Prompt for AI Agents
Comment on lines
+10
to
+16
There was a problem hiding this comment. 🧩 Analysis chain🌐 Web query:
💡 Result: Summary — createTool execute handler (Mastra)
Sources
🏁 Script executed: find . -name "color-change-tool.ts" -type f | head -5Repository: ssdeanx/AgentStack Length of output: 95 🏁 Script executed: rg "createTool" --type ts --type tsx -A 10 -B 2Repository: ssdeanx/AgentStack Length of output: 89 🏁 Script executed: cat -n ./src/mastra/color-change-tool.tsRepository: ssdeanx/AgentStack Length of output: 567 🏁 Script executed: rg "changeBgColor" --type ts --type jsRepository: ssdeanx/AgentStack Length of output: 140 🏁 Script executed: rg "createTool" -A 10 -B 2Repository: ssdeanx/AgentStack Length of output: 50377 Add missing execute handler to tool. The Use the v1 signature format: export const colorChangeTool = createTool({
id: "changeColor",
description: "Changes the background color",
inputSchema: z.object({
color: z.string(),
}),
+ execute: async (inputData) => {
+ changeBgColor(inputData.color);
+ return { success: true, color: inputData.color };
+ },
});
|
||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -4,7 +4,7 @@ import { logError } from './logger' | |
| //import { GoogleVoice } from "@mastra/voice-google"; | ||
| import { GoogleGenerativeAIImageProviderOptions } from '@ai-sdk/google'; | ||
| import { experimental_generateImage as generateImage } from 'ai'; | ||
| import { GoogleVoice } from "@mastra/voice-google"; | ||
| // Initialize with custom configuration | ||
| //export const gvoice = new GoogleVoice({ | ||
| // speechModel: { | ||
|
|
@@ -43,6 +43,17 @@ export const google = createGoogleGenerativeAI({ | |
| apiKey: process.env.GOOGLE_GENERATIVE_AI_API_KEY, | ||
| }) | ||
|
|
||
| // Google Voice Configuration | ||
| export const voice = new GoogleVoice({ | ||
| speechModel: { | ||
| apiKey: process.env.GOOGLE_API_KEY, | ||
| }, | ||
| listeningModel: { | ||
| apiKey: process.env.GOOGLE_API_KEY, | ||
| }, | ||
| speaker: "en-US-Casual-N", | ||
| }); | ||
|
|
||
| // Chat/Text Models | ||
| export const googleChatModels = { | ||
| // Gemini 3 Pro model for higher-performance applications | ||
|
|
||
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -7,7 +7,7 @@ | |
|
|
||
| ## Persona | ||
|
|
||
| **Name:** Senior Tooling & Integrations Engineer | ||
| **Role Objective:** Provide minimal, secure, schema-bound callable functions enabling agent actions with clear natural language affordances. | ||
|
|
||
| ## Purpose | ||
|
|
@@ -77,6 +77,8 @@ Encapsulate 30+ atomic operational capabilities (security checks, vector queries | |
| | Data Processing Tools | General data processing |  | Various | - | [data-processing-tools.ts](./data-processing-tools.ts) | | ||
| | PDF | PDF utilities |  | `pdfTool` | `pdf-parse` | [pdf.ts](./pdf.ts) | | ||
| | SerpAPI Config | SerpAPI configuration |  | Config exports | `serpapi` | [serpapi-config.ts](./serpapi-config.ts) | | ||
| | Code Search | Search for patterns across source files. Supports string and regex patterns with context lines. Use for finding usages, identifying patterns, and code exploration. |  | `codeSearchTool` | `fast-glob`, `zod`, `re2` | [code-search.tool.ts](./code-search.tool.ts) | | ||
| | Find Symbol | Find symbol definitions (functions, classes, variables) across the codebase using semantic analysis. |  | `findSymbolTool` | `ts-morph`, `zod`, `fast-glob` | [find-symbol.tool.ts](./find-symbol.tool.ts) | | ||
|
|
||
| ### 6. 📈 Financial Chart Tools | ||
|  | ||
|
|
@@ -118,7 +120,47 @@ export const yourTool = createTool({ | |
| - **Error Handling**: Try-catch, clear messages, retries for APIs. | ||
| - **Security**: Sanitize inputs, mask secrets, rate-limit. | ||
| - **Performance**: Cache, stream large data, timeouts. | ||
| - **Observability**: Otel spans on all executes. | ||
|
|
||
| ### Data Tool Progress Events | ||
|
|
||
| All tools must emit progress events with this exact format: | ||
|
|
||
| ```typescript | ||
| // ✅ CORRECT: Progress event format | ||
| await context?.writer?.custom({ | ||
| type: "data-tool-progress", | ||
| data: { | ||
| status: "in-progress", // "in-progress" | "done" | ||
| message: "Descriptive progress message...", | ||
| stage: "tool-name" // Tool identifier (same as id) | ||
| }, | ||
| id: "tool-name" // Tool identifier outside data object | ||
| }); | ||
|
|
||
| // ❌ WRONG: Don't put id inside data object | ||
| await context?.writer?.custom({ | ||
| type: "data-tool-progress", | ||
| data: { | ||
| id: "tool-name", // ❌ Wrong - id belongs outside | ||
| message: "..." | ||
| } | ||
| }); | ||
| ``` | ||
|
|
||
| **Example from Alpha Vantage Tool:** | ||
|
|
||
| ```typescript | ||
| await context?.writer?.custom({ | ||
| type: 'data-tool-progress', | ||
| data: { | ||
| status: 'in-progress', | ||
| message: `📈 Fetching Alpha Vantage crypto data for ${inputData.symbol}/${inputData.market}`, | ||
| stage: 'alpha-vantage-crypto' | ||
| }, | ||
| id: 'alpha-vantage-crypto' | ||
| }); | ||
| ``` | ||
|
|
||
| ## Testing | ||
| 97% coverage via Vitest. Run: | ||
|
|
||
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There appears to be a typo in the todo list example. The sub-step numbering for "Step 2" is incorrect and seems to be a copy-paste from "Step 1". It should likely be
Sub-step 2.2.