Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add optional descriptions #88

Merged
merged 7 commits into from
Nov 15, 2023
Merged

Conversation

tharwan
Copy link

@tharwan tharwan commented Nov 9, 2023

This PR adresses #86

Copy link
Member

@dokempf dokempf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is looking good. My only concern is that it currently only applies to those widgets that went through _construct_simple - missing e.g. all formats, object and array. But then again, similar things can be said about tooltips, I guess. If you have the capacity to extend the feature to these additional types, feel free to do so. If you do not have it, I am also fine with merging as is, as it is an improvement over the status quo.

tests/test_form.py Outdated Show resolved Hide resolved
@tharwan
Copy link
Author

tharwan commented Nov 10, 2023

This is looking good. My only concern is that it currently only applies to those widgets that went through _construct_simple - missing e.g. all formats, object and array. But then again, similar things can be said about tooltips, I guess. If you have the capacity to extend the feature to these additional types, feel free to do so. If you do not have it, I am also fine with merging as is, as it is an improvement over the status quo.

I was not sure how to do it for the composed formats, but I also think it is most needed for the actual input fields which all go through the construct_simple.

@tharwan
Copy link
Author

tharwan commented Nov 15, 2023

I would be very happy if we could merge this soon.

@dokempf
Copy link
Member

dokempf commented Nov 15, 2023

@tharwan I implemented the missing types (array, object and datetime formats). With this change, I think I am ready to go.

@dokempf dokempf merged commit 461c67f into ssciwr:main Nov 15, 2023
9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants