-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add optional descriptions #88
Conversation
for more information, see https://pre-commit.ci
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is looking good. My only concern is that it currently only applies to those widgets that went through _construct_simple
- missing e.g. all formats, object and array. But then again, similar things can be said about tooltips, I guess. If you have the capacity to extend the feature to these additional types, feel free to do so. If you do not have it, I am also fine with merging as is, as it is an improvement over the status quo.
I was not sure how to do it for the composed formats, but I also think it is most needed for the actual input fields which all go through the construct_simple. |
…re/descriptions # Conflicts: # tests/test_form.py
for more information, see https://pre-commit.ci
I would be very happy if we could merge this soon. |
@tharwan I implemented the missing types (array, object and datetime formats). With this change, I think I am ready to go. |
This PR adresses #86